Skip to content

Commit

Permalink
UPSTREAM: 52092: Fix resource quota controller panic (Drop in 1.8)
Browse files Browse the repository at this point in the history
The pod evaluator used by the resource quota controller made direct
calls to an unsafe pod conversion function which mutates the pod
argument. With multiple resource quota controller workers, concurrent
processing of the same pod from a shared informer can result in a panic
when the conversion code attempts to write to a map field in the pod.

Swap out the direct conversion function call to Scheme.ConvertToVersion,
which copies the input before conversion.
  • Loading branch information
ironcladlou committed Sep 8, 2017
1 parent 72f5bc5 commit 556fe48
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions vendor/k8s.io/kubernetes/pkg/quota/evaluator/core/pods.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 556fe48

Please sign in to comment.