Skip to content

Commit

Permalink
Fix rhbz # 1587824. With experimental-allowed-unsafe-sysctls,
Browse files Browse the repository at this point in the history
"*" is a valid character now as part of kubelet arguments.
  • Loading branch information
aveshagarwal committed Jun 8, 2018
1 parent f62ffd8 commit 59b425b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/cmd/server/origin/node/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
// safeArgRegexp matches only characters that are known safe. DO NOT add to this list
// without fully considering whether that new character can be used to break shell escaping
// rules.
var safeArgRegexp = regexp.MustCompile(`^[\da-zA-Z\-=_\.,/\:]+$`)
var safeArgRegexp = regexp.MustCompile(`^[\da-zA-Z\-=_\.,/\:\*]+$`)

// shellEscapeArg quotes an argument if it contains characters that my cause a shell
// interpreter to split the single argument into multiple.
Expand Down

0 comments on commit 59b425b

Please sign in to comment.