Skip to content

Commit

Permalink
Merge pull request #18255 from joelsmith/master
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue (batch tested with PRs 18423, 18255, 18526, 18539, 18509).

UPSTREAM: 58720: Ensure that the runtime mounts RO volumes read-only

This is a backport of kubernetes/kubernetes#58720

This change makes it so that containers cannot write to secret, configMap, downwardAPI and projected volumes since the runtime will now mount them read-only. This change makes things less confusing for a user since any attempt to update a secret volume will result in an error rather than a successful change followed by a revert by the kubelet when the volume next syncs.

**Which issue(s) this PR fixes**
N/A

**Release note**:
```
Containers now mount secret, configMap, downwardAPI and projected volumes read-only.

```
  • Loading branch information
openshift-merge-robot authored Feb 9, 2018
2 parents acfac49 + 62cd305 commit 6ce0af0
Show file tree
Hide file tree
Showing 5 changed files with 53 additions and 42 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions vendor/k8s.io/kubernetes/pkg/features/kube_features.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion vendor/k8s.io/kubernetes/pkg/kubelet/kubelet_pods.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 21 additions & 21 deletions vendor/k8s.io/kubernetes/test/e2e/common/downwardapi_volume.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 18 additions & 18 deletions vendor/k8s.io/kubernetes/test/e2e/common/projected.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6ce0af0

Please sign in to comment.