Skip to content

Commit

Permalink
Always enable kube-proxy and dns metrics
Browse files Browse the repository at this point in the history
  • Loading branch information
smarterclayton committed Jun 13, 2018
1 parent 8b926da commit 831e53a
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions pkg/cmd/server/kubernetes/network/options/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,8 @@ func Build(options configapi.NodeConfig) (*kubeproxyconfig.KubeProxyConfiguratio
return nil, fmt.Errorf("The provided value to bind to must be an ip:port: %q", addr)
}
proxyconfig.BindAddress = ip.String()
// MetricsBindAddress - disable by default but allow enablement until we switch to
// reading proxy config directly
proxyconfig.MetricsBindAddress = ""
// MetricsBindAddress - enable as a separate port for now, but only on localhost
proxyconfig.MetricsBindAddress = "localhost:10257"
if arg := options.ProxyArguments["metrics-bind-address"]; len(arg) > 0 {
proxyconfig.MetricsBindAddress = arg[0]
}
Expand Down

0 comments on commit 831e53a

Please sign in to comment.