Skip to content

Commit

Permalink
UPSTREAM: <drop>: make RootFsInfo error non-fatal on start
Browse files Browse the repository at this point in the history
  • Loading branch information
@liggitt
liggitt committed Apr 7, 2018
1 parent f208088 commit b61c00c
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions vendor/k8s.io/kubernetes/pkg/kubelet/cm/container_manager_linux.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 comments on commit b61c00c

@liggitt
Copy link
Contributor Author

@liggitt liggitt commented on b61c00c Jun 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekwaynecarr @sjenning what did we decide to do with this?

@sjenning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, this should be behind the feature gate for LocalStorageIsolation. I'm surprised that it isn't.

Might go upstream and make that change.

Either way, we have two options long term:

  1. change CI so it doesn't do what EphemeralStorageCapacityFromFsInfo() can't handle
  2. change upstream to handle the case that CI exposes.

@derekwaynecarr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with @sjenning

Please sign in to comment.