Skip to content

Commit

Permalink
Cleanup duplicate checking for empty images in DC controller loop
Browse files Browse the repository at this point in the history
  • Loading branch information
tnozicka committed Feb 8, 2018
1 parent 14fd676 commit ba4e314
Showing 1 changed file with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -181,14 +181,6 @@ func (c *DeploymentConfigController) Handle(config *appsapi.DeploymentConfig) er
return c.reconcileDeployments(existingDeployments, config, cm)
}

// Never deploy with invalid or unresolved images
for i, container := range config.Spec.Template.Spec.Containers {
if len(strings.TrimSpace(container.Image)) == 0 {
glog.V(4).Infof("Postponing rollout #%d for DeploymentConfig %s/%s because of invalid or unresolved image for container #%d (name=%s)", config.Status.LatestVersion, config.Namespace, config.Name, i, container.Name)
return c.updateStatus(config, existingDeployments, true)
}
}

// No deployments are running and the latest deployment doesn't exist, so
// create the new deployment.
deployment, err := appsutil.MakeDeploymentV1(config, c.codec)
Expand Down

0 comments on commit ba4e314

Please sign in to comment.