Skip to content

Commit

Permalink
Merge pull request #14838 from php-coder/backport_sa_and_secrets_stor…
Browse files Browse the repository at this point in the history
…age_config

Merged by openshift-bot
  • Loading branch information
OpenShift Bot authored Jul 7, 2017
2 parents 06c65e8 + ab93dcd commit e0c904f
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 8 deletions.
18 changes: 15 additions & 3 deletions pkg/cmd/server/origin/master_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -900,14 +900,26 @@ func newServiceAccountTokenGetter(options configapi.MasterConfig) (serviceaccoun
return nil, err
}

storageConfig, err := kubeStorageFactory.NewConfig(kapi.Resource("serviceaccounts"))
storageConfigServiceAccounts, err := kubeStorageFactory.NewConfig(kapi.Resource("serviceaccounts"))
if err != nil {
return nil, err
}
storageConfigSecrets, err := kubeStorageFactory.NewConfig(kapi.Resource("secrets"))
if err != nil {
return nil, err
}

// TODO: by doing this we will not be able to authenticate while a master quorum is not present - reimplement
// as two storages called in succession (non quorum and then quorum).
storageConfig.Quorum = true
return sacontroller.NewGetterFromStorageInterface(storageConfig, kubeStorageFactory.ResourcePrefix(kapi.Resource("serviceaccounts")), kubeStorageFactory.ResourcePrefix(kapi.Resource("secrets"))), nil
storageConfigServiceAccounts.Quorum = true
storageConfigSecrets.Quorum = true

return sacontroller.NewGetterFromStorageInterface(
storageConfigServiceAccounts,
kubeStorageFactory.ResourcePrefix(kapi.Resource("serviceaccounts")),
storageConfigSecrets,
kubeStorageFactory.ResourcePrefix(kapi.Resource("secrets")),
), nil
}

func newAuthenticator(config configapi.MasterConfig, restOptionsGetter restoptions.Getter, tokenGetter serviceaccount.ServiceAccountTokenGetter, apiClientCAs *x509.CertPool, groupMapper identitymapper.UserToGroupMapper) (authenticator.Request, error) {
Expand Down
13 changes: 11 additions & 2 deletions vendor/k8s.io/kubernetes/cmd/kube-apiserver/app/server.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit e0c904f

Please sign in to comment.