Skip to content

Commit

Permalink
UPSTREAM: 52127: Fix deployment timeout reporting
Browse files Browse the repository at this point in the history
If the previous condition has been a successful rollout then we
shouldn't try to estimate any progress. Scenario:

* progressDeadlineSeconds is smaller than the difference between
  now and the time the last rollout finished in the past.
* the creation of a new ReplicaSet triggers a resync of the
  Deployment prior to the cached copy of the Deployment getting
  updated with the status.condition that indicates the creation
   of the new ReplicaSet.

The Deployment will be resynced and eventually its Progressing
condition will catch up with the state of the world.

Signed-off-by: Michail Kargakis <[email protected]>
  • Loading branch information
0xmichalis authored and cherrypicker committed Nov 2, 2017
1 parent e541658 commit f079995
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 4 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f079995

Please sign in to comment.