Skip to content

Commit

Permalink
Fix deployment config UpdateScale
Browse files Browse the repository at this point in the history
  • Loading branch information
liggitt committed Nov 30, 2017
1 parent c5e3dc8 commit f698138
Show file tree
Hide file tree
Showing 7 changed files with 60 additions and 29 deletions.
1 change: 0 additions & 1 deletion pkg/apps/apis/apps/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ const (
// +genclient:method=Instantiate,verb=create,subresource=instantiate,input=DeploymentRequest
// +genclient:method=Rollback,verb=create,subresource=rollback,input=DeploymentConfigRollback
// +genclient:method=GetScale,verb=get,subresource=scale,result=k8s.io/kubernetes/pkg/apis/extensions/v1beta1.Scale
// +genclient:method=UpdateScale,verb=update,subresource=scale,input=k8s.io/kubernetes/pkg/apis/extensions/v1beta1.Scale,result=k8s.io/kubernetes/pkg/apis/extensions/v1beta1.Scale
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object

// DeploymentConfig represents a configuration for a single deployment (represented as a
Expand Down
10 changes: 10 additions & 0 deletions pkg/apps/generated/internalclientset/scheme/register_expansion.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package scheme

import (
extensionsv1beta1 "k8s.io/kubernetes/pkg/apis/extensions/v1beta1"
)

func init() {
// Needed for GetScale/UpdateScale
extensionsv1beta1.AddToScheme(Scheme)
}
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ type DeploymentConfigInterface interface {
Instantiate(deploymentConfigName string, deploymentRequest *apps.DeploymentRequest) (*apps.DeploymentConfig, error)
Rollback(deploymentConfigName string, deploymentConfigRollback *apps.DeploymentConfigRollback) (*apps.DeploymentConfig, error)
GetScale(deploymentConfigName string, options v1.GetOptions) (*v1beta1.Scale, error)
UpdateScale(deploymentConfigName string, scale *v1beta1.Scale) (*v1beta1.Scale, error)

DeploymentConfigExpansion
}
Expand Down Expand Up @@ -202,17 +201,3 @@ func (c *deploymentConfigs) GetScale(deploymentConfigName string, options v1.Get
Into(result)
return
}

// UpdateScale takes the top resource name and the representation of a scale and updates it. Returns the server's representation of the scale, and an error, if there is any.
func (c *deploymentConfigs) UpdateScale(deploymentConfigName string, scale *v1beta1.Scale) (result *v1beta1.Scale, err error) {
result = &v1beta1.Scale{}
err = c.client.Put().
Namespace(c.ns).
Resource("deploymentconfigs").
Name(deploymentConfigName).
SubResource("scale").
Body(scale).
Do().
Into(result)
return
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package internalversion

import (
"k8s.io/apimachinery/pkg/runtime"
kapi "k8s.io/kubernetes/pkg/api"
v1beta1 "k8s.io/kubernetes/pkg/apis/extensions/v1beta1"
)

type DeploymentConfigExpansion interface {
UpdateScale(deploymentConfigName string, scale *v1beta1.Scale) (result *v1beta1.Scale, err error)
}

var scaleCodec = kapi.Codecs.LegacyCodec(v1beta1.SchemeGroupVersion)

// UpdateScale takes the top resource name and the representation of a scale and updates it. Returns the server's representation of the scale, and an error, if there is any.
func (c *deploymentConfigs) UpdateScale(deploymentConfigName string, scale *v1beta1.Scale) (result *v1beta1.Scale, err error) {
// FIXME: make non-homogenous subresource GV client generation work
data, err := runtime.Encode(scaleCodec, scale)
if err != nil {
return nil, err
}

result = &v1beta1.Scale{}
err = c.client.Put().
Namespace(c.ns).
Resource("deploymentconfigs").
Name(deploymentConfigName).
SubResource("scale").
Body(data).
Do().
Into(result)
return
}
Original file line number Diff line number Diff line change
Expand Up @@ -154,14 +154,3 @@ func (c *FakeDeploymentConfigs) GetScale(deploymentConfigName string, options v1
}
return obj.(*v1beta1.Scale), err
}

// UpdateScale takes the representation of a scale and updates it. Returns the server's representation of the scale, and an error, if there is any.
func (c *FakeDeploymentConfigs) UpdateScale(deploymentConfigName string, scale *v1beta1.Scale) (result *v1beta1.Scale, err error) {
obj, err := c.Fake.
Invokes(testing.NewUpdateSubresourceAction(deploymentconfigsResource, "scale", c.ns, scale), &v1beta1.Scale{})

if obj == nil {
return nil, err
}
return obj.(*v1beta1.Scale), err
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package fake

import (
testing "k8s.io/client-go/testing"
v1beta1 "k8s.io/kubernetes/pkg/apis/extensions/v1beta1"
)

// UpdateScale takes the representation of a scale and updates it. Returns the server's representation of the scale, and an error, if t
func (c *FakeDeploymentConfigs) UpdateScale(deploymentConfigName string, scale *v1beta1.Scale) (result *v1beta1.Scale, err error) {
obj, err := c.Fake.
Invokes(testing.NewUpdateSubresourceAction(deploymentconfigsResource, "scale", c.ns, scale), &v1beta1.Scale{})

if obj == nil {
return nil, err
}
return obj.(*v1beta1.Scale), err
}
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
package internalversion

type DeploymentConfigExpansion interface{}

0 comments on commit f698138

Please sign in to comment.