"invalid memory address or nil pointer dereference" when ListClusterPolicyBindings returns an error #15747
Assignees
Labels
Comments
simo5
added a commit
to simo5/origin
that referenced
this issue
Aug 11, 2017
In some policy{binding} function a conversion is performed after listing,
but error checking is not properly performed on the previous listing
function return.
This can cause panics on errors.
Fixes openshift#15747
Signed-off-by: Simo Sorce <[email protected]>
pweil-
added
area/tests
kind/bug
|
Testing this out, I may just cherrypick it into my branch and let it sit for a while since repo may be annoying. |
smarterclayton
pushed a commit
to smarterclayton/origin
that referenced
this issue
Aug 11, 2017
In some policy{binding} function a conversion is performed after listing,
but error checking is not properly performed on the previous listing
function return.
This can cause panics on errors.
Fixes openshift#15747
Signed-off-by: Simo Sorce <[email protected]>
openshift-merge-robot
added a commit
that referenced
this issue
Aug 13, 2017
Automatic merge from submit-queue (batch tested with PRs 15657, 15748)
Properly handle errors in policy listing
In some policy{binding} function a conversion is performed after listing,
but error checking is not properly performed on the previous listing
function return.
This can cause panics on errors.
Fixes #15747
simo5
added a commit
to simo5/origin
that referenced
this issue
Aug 14, 2017
In some policy{binding} function a conversion is performed after listing,
but error checking is not properly performed on the previous listing
function return.
This can cause panics on errors.
Fixes openshift#15747
Signed-off-by: Simo Sorce <[email protected]>
openshift-merge-robot
added a commit
that referenced
this issue
Aug 16, 2017
Automatic merge from submit-queue
Properly handle errors in policy listing
In some policy{binding} function a conversion is performed after listing,
but error checking is not properly performed on the previous listing
function return.
This can cause panics on errors.
Fixed for master, #15747 via #15748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A panic happens in some tests when ListClusterPolicyBindings() returns an error when called by ListPolicyBindings()
Triggered by PR #15605
Version
Current master tree
The issue is caused by incorrect error handling
The text was updated successfully, but these errors were encountered: