Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended.[builds][Slow] starting a build using CLI Setting build-args on Docker builds Should fail on non-existent build-arg #16197

Closed
bparees opened this issue Sep 7, 2017 · 4 comments
Closed

Extended.[builds][Slow] starting a build using CLI Setting build-args on Docker builds Should fail on non-existent build-arg #16197

bparees opened this issue Sep 7, 2017 · 4 comments
Assignees
@coreydaley
Labels
component/build kind/test-flake Categorizes issue or PR as related to test flakes. priority/P1

Comments

@bparees
Copy link
Contributor

bparees commented Sep 7, 2017 

/go/src/github.com/openshift/origin/test/extended/builds/start.go:319
Expected
    <bool>: false
to be true
/go/src/github.com/openshift/origin/test/extended/builds/start.go:314

https://ci.openshift.redhat.com/jenkins/job/test_branch_origin_extended_builds/197

Looks like the build succeeded when we expected it to fail because we didn't supply all the ARGs values that the Dockerfile declared. Did docker change its behavior?

(marking as a flake for now, but this doesn't seem like something that would be intermittent)
@bparees bparees added component/build kind/test-flake Categorizes issue or PR as related to test flakes. priority/P1 labels Sep 7, 2017
@coreydaley
Copy link
Member

Looks like the message was changed from an error to a warning in v1.13.0-rc1 (moby/moby@f150f42), and also the ', failing build' was removed as it is a warning now instead of an error, I will update the test.

@coreydaley coreydaley mentioned this issue Sep 7, 2017
Merged
@coreydaley
Copy link
Member

PR #16212 submitted to fix this issue.

@bparees
Copy link
Contributor Author

bparees commented Sep 7, 2017

thanks for the speed turnaround, @coreydaley

@coreydaley
Copy link
Member

@bparees word

openshift-merge-robot added a commit that referenced this issue Sep 8, 2017
@openshift-merge-robot
Merge pull request #16212 from coreydaley/github_16197_fix_failing_do…
72f5bc5 
…cker_build_arg_test

Automatic merge from submit-queue (batch tested with PRs 16202, 16198, 16212)

Updating docker --build-arg test due to docker code change

Docker changed the error for a non-existent --build-arg to a warning
and changed the text of the message slightly, breaking one of our tests.
Docker change: moby/moby@f150f42

Fixes: #16197
deads2k pushed a commit to deads2k/origin that referenced this issue Sep 26, 2017
@coreydaley @deads2k
Updating docker --build-arg test due to docker code change
ea49279 
Docker changed the error for a non-existent --build-arg to a warning
and changed the text of the message slightly, breaking one of our tests.
Docker change: moby/moby@f150f42

Fixes: openshift#16197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coreydaley coreydaley

Labels
component/build kind/test-flake Categorizes issue or PR as related to test flakes. priority/P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bparees @coreydaley