Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended cl.go tests fails to define all template parameters #17068

Closed
jmencak opened this issue Oct 27, 2017 · 2 comments
Closed

Extended cl.go tests fails to define all template parameters #17068

jmencak opened this issue Oct 27, 2017 · 2 comments
Assignees
Labels
area/tests component/internal-tools priority/P2 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Comments

@jmencak
Copy link
Contributor

jmencak commented Oct 27, 2017

Version

$ git describe
v3.7.0-alpha.1-494-g7bb08c04da

Steps To Reproduce
  1. extended.test --ginkgo.focus="Load cluster" --viper-config=config/stress-mb
Current Result

Only the first template parameter 'RUN: mb' is overrriden during the extended test run:
Oct 27 14:56:14.777: INFO: Running 'oc new-app --config=/tmp/extended-test-cl-jgpj6-hg8kn-user.kubeconfig --namespace=cll0 centos-stress-template -p RUN=mb'

Expected Result

All template parameters defined.

Config files
  • stress-mb.yaml

    # e2e specific vars
    provider: local
    # delete namespace after exec
    deletenamespace: true
    # Cluster loader specific part
    ClusterLoader:
      projects:
        - num: 1
          basename: cll
          tuning: default
          routes: wlg-targets
          templates:
            - num: 1
              file: quickstarts/stress/stress-pod.json
              parameters:
                RUN: mb
                PLACEMENT: test
                MB_DELAY: 100
                MB_TARGETS: ^cakephp-
                MB_CONNS_PER_TARGET: 1
                MB_KA_REQUESTS: 100
                MB_TLS_SESSION_REUSE: y
                MB_RAMP_UP: 60
                URL_PATH: /
      tuningsets: 
        - name: default
          pods:
            stepping:
              stepsize: 5
              pause: 3      # seconds
              timeout: 300  # seconds
            ratelimit:
              delay: 100    # milliseconds
          templates:
            stepping: 
              stepsize: 2
              pause: 2      # seconds
              timeout: 120  # seconds
            ratelimit: 
              delay: 200    # milliseconds
    
  • https://raw.githubusercontent.com/openshift/svt/master/openshift_scalability/content/quickstarts/stress/stress-pod.json

@sjug /cc @jeremyeder

@sjug sjug self-assigned this Oct 27, 2017
@sjug
Copy link
Contributor

sjug commented Oct 27, 2017

The problem is the yaml is getting unmashalled to a struct which doesn't match the parameters (snip).

@sjug sjug added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/tests labels Oct 27, 2017
@sjug
Copy link
Contributor

sjug commented Oct 27, 2017

Fixed by #17072

openshift-merge-robot added a commit that referenced this issue Dec 21, 2017
Automatic merge from submit-queue (batch tested with PRs 17072, 17616).

Remove hardcoded fields for parameter substitution configuration in Cluster Loader

Fixes #17068

This should enable us to remove `fatih/structs` as a vendor dep as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests component/internal-tools priority/P2 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

No branches or pull requests

3 participants