Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSSAPI extended tests broken due to error type loss #17136

Closed
enj opened this issue Nov 2, 2017 · 0 comments
Closed

GSSAPI extended tests broken due to error type loss #17136

enj opened this issue Nov 2, 2017 · 0 comments
Assignees
@juanvallejo
Labels
area/tests component/cli priority/P1 sig/security
Milestone
v3.7

Comments

@enj
Copy link
Contributor

enj commented Nov 2, 2017

#17073 broke the types of errors returned from pkg/oc/cli/cmd/login/loginoptions.go. This breaks how pkg/oc/cli/cmd/login/login.go handles unauthorized errors.

=== BEGIN TEST CASE ===
/run/os/gssapi-tests.sh:30: executing 'oc login' expecting failure and text 'Login failed \(401 Unauthorized\)'
FAILURE after 0.460s: /run/os/gssapi-tests.sh:30: executing 'oc login' expecting failure and text 'Login failed \(401 Unauthorized\)': the output content test failed
There was no output from the command.
Standard error from the command:
error: unhandled challenge - verify you have provided the correct host and port and that the server is currently running.
=== END TEST CASE ===
@enj enj added this to the 3.7.0 milestone Nov 2, 2017
@juanvallejo juanvallejo mentioned this issue Nov 2, 2017
Merged
@enj enj mentioned this issue Nov 2, 2017
Closed
openshift-merge-robot added a commit that referenced this issue Nov 4, 2017
@openshift-merge-robot
Merge pull request #17138 from juanvallejo/jvallejo/preserve-err-type…
12f0ec1 
…-loginoptions

Automatic merge from submit-queue (batch tested with PRs 17178, 17141, 17138).

preserve err type loginoptions

Fixes #17136
Fixes #17150

Preserves the error  type returned in https://github.com/openshift/origin/blob/master/pkg/oc/cli/cmd/login/loginoptions.go#L237

cc @openshift/cli-review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juanvallejo juanvallejo

Labels
area/tests component/cli priority/P1 sig/security
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
2 participants
@juanvallejo @enj