-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image resource quota should deny a push of built image exceeding openshift.io/imagestreams quota #17786
Comments
Looks like the rebase broke quota for image streams. |
well that didn't take long(for an origin change to break image-registry while passing all origin tests). @stevekuznetsov @smarterclayton what is our plan for having cohesive CI across repos such that origin PRs actually have to pass the tests of their dependent repos? |
What job did this break in? We are running the registry tests in Origin e2e |
And which PR in Origin broke the registry but passed the tests? |
Like, if the registry built and deployed from |
@stevekuznetsov #17786 (comment) So are we really running the image-registry extended tests against origin repo PRs? |
@stevekuznetsov #17576 |
@deads2k the broken quota issue i just mentioned to you. |
IIRC some of the registry tests were in the normal conformance e2e bucket, no? Other than that -- unless we want to make the image registry job mandatory, it should have been on the author of the rebase PR to run the other tests as well. |
@bparees because I know nothing about quota. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/lifecycle frozen |
/kind test-flake
The text was updated successfully, but these errors were encountered: