Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add our types to the kubectl scheme #17793

Closed
deads2k opened this issue Dec 14, 2017 · 0 comments
Closed

Add our types to the kubectl scheme #17793

deads2k opened this issue Dec 14, 2017 · 0 comments
Assignees
@juanvallejo
Labels
kind/post-rebase
Milestone
v3.9

Comments

@deads2k
Copy link
Contributor

deads2k commented Dec 14, 2017

add our types to the kubectl scheme and drop UPSTREAM: <carry>: switch apply to use the legacyscheme so our types can be handled
@deads2k deads2k added this to the 3.9.0 milestone Dec 14, 2017
@deads2k deads2k mentioned this issue Dec 14, 2017
Merged
25 tasks
@juanvallejo juanvallejo mentioned this issue Dec 14, 2017
Closed
@deads2k deads2k mentioned this issue Dec 19, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Dec 20, 2017
@openshift-merge-robot
Merge pull request #17885 from deads2k/api-14-legacyinstall
499023e 
Automatic merge from submit-queue (batch tested with PRs 17859, 17885).

Add origin types kubectl scheme 

Fixes #17793 

Builds on #17815

/assign sttts
/assign juanvallejo

This centralizes the legacy install function. The next logical step is going to require that we start plumbing particular schemes or build individual schemes.  I looked at doing that here, but it appears we have some 500 hits just for scheme usage and I haven't decided the optimal solution for something like our graph yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juanvallejo juanvallejo

Labels
kind/post-rebase
Projects
None yet
Milestone
v3.9
Development

No branches or pull requests
2 participants
@juanvallejo @deads2k