Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestRouter flakiness #17924

Closed
soltysh opened this issue Dec 22, 2017 · 10 comments
Closed

TestRouter flakiness #17924

soltysh opened this issue Dec 22, 2017 · 10 comments
Assignees
@knobunc
Labels
component/networking kind/test-flake Categorizes issue or PR as related to test flakes. priority/P0

Comments

@soltysh
Copy link
Contributor

soltysh commented Dec 22, 2017 

=== RUN   TestRouter
--- FAIL: TestRouter (0.00s)
	router_test.go:1416: Error validating master addr 172.18.15.1:8080 : Get https://172.18.15.1:8443: dial tcp 172.18.15.1:8443: getsockopt: connection refused
	router_test.go:62: Unable to start http server: tls: failed to find any PEM data in certificate input
=== RUN   TestRouterPathSpecificity
--- FAIL: TestRouterPathSpecificity (0.00s)
	router_test.go:393: Unable to start http server: tls: failed to find any PEM data in certificate input
=== RUN   TestRouterDuplications
--- FAIL: TestRouterDuplications (0.00s)
	router_test.go:752: Unable to start http server: listen tcp 172.18.15.1:8080: bind: address already in use
=== RUN   TestRouterStatsPort
--- FAIL: TestRouterStatsPort (0.00s)
	router_test.go:884: Unable to start http server: listen tcp 172.18.15.1:8080: bind: address already in use
=== RUN   TestRouterHealthzEndpoint
--- FAIL: TestRouterHealthzEndpoint (0.00s)
	router_test.go:937: Unable to start http server: listen tcp 172.18.15.1:8080: bind: address already in use
=== RUN   TestRouterServiceUnavailable
--- FAIL: TestRouterServiceUnavailable (0.00s)
	router_test.go:975: Unable to start http server: listen tcp 172.18.15.1:8080: bind: address already in use
=== RUN   TestRouterReloadCoalesce
--- FAIL: TestRouterReloadCoalesce (0.00s)
	router_test.go:1416: Error validating master addr 172.18.15.1:8080 : Get https://172.18.15.1:8443: dial tcp 172.18.15.1:8443: getsockopt: connection refused
	router_test.go:1525: Unable to start http server: listen tcp 172.18.15.1:8080: bind: address already in use
=== RUN   TestRouterBindsPortsAfterSync
--- FAIL: TestRouterBindsPortsAfterSync (3.46s)
	router_test.go:1416: Error validating master addr 172.18.15.1:8080 : Get https://172.18.15.1:8443: dial tcp 172.18.15.1:8443: getsockopt: connection refused
	router_test.go:1674: Unable to start http server: listen tcp 172.18.15.1:8080: bind: address already in use
=== RUN   TestIngressConfiguredRouter
--- FAIL: TestIngressConfiguredRouter (0.00s)
	router_test.go:1416: Error validating master addr 172.18.15.1:8080 : Get https://172.18.15.1:8443: dial tcp 172.18.15.1:8443: getsockopt: connection refused
	router_test.go:1721: Unable to start http server: listen tcp 172.18.15.1:8080: bind: address already in use

Seen in #17868, #17860

Logs:
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/17868/test_pull_request_origin_end_to_end/7174/build-log.txt, https://storage.googleapis.com/origin-ci-test/pr-logs/pull/17860/test_pull_request_origin_end_to_end/7145/build-log.txt

@openshift/sig-networking
@soltysh soltysh added component/networking kind/test-flake Categorizes issue or PR as related to test flakes. priority/P1 labels Dec 22, 2017
@tnozicka
Copy link
Contributor

tnozicka commented Jan 2, 2018

also on release-3.7 https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/17620/test_pull_request_origin_end_to_end/7355/

@tnozicka
Copy link
Contributor

tnozicka commented Jan 2, 2018

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/17599/test_pull_request_origin_end_to_end/7339/

blocks release-3.7 branch

This was referenced Jan 2, 2018
Merged
Merged
@tnozicka
Copy link
Contributor

tnozicka commented Jan 2, 2018

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/17620/test_pull_request_origin_end_to_end/7360/

@tnozicka
Copy link
Contributor

tnozicka commented Jan 2, 2018

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/17599/test_pull_request_origin_end_to_end/7361/

@tnozicka
Copy link
Contributor

tnozicka commented Jan 2, 2018

@stevekuznetsov can this be test-infra related?

@enj
Copy link
Contributor

enj commented Jan 2, 2018

blocks release-3.7 branch

I have seen this as well: https://openshift-gce-devel.appspot.com/pr/17789

@sjenning
Copy link
Contributor

sjenning commented Jan 2, 2018

My PR on the 3.8 branch is hitting this on every run
https://openshift-gce-devel.appspot.com/pr/17839

@sjenning
Copy link
Contributor

sjenning commented Jan 2, 2018

Same on a 3.7 PR (merged manually):
https://openshift-gce-devel.appspot.com/pr/17722

@sjenning sjenning mentioned this issue Jan 2, 2018
Merged
@stevekuznetsov
Copy link
Contributor

If it's hitting 3.7 and 3.8 I would expect this to be a Go version issue. We have not had the possibility of testing non-master Origin PRs with different versions of Go ever in the past, so I would expect those tests to simply be broken. I would suggest testing locally and merging manually for now. We anticipate better support in the future.

@JacobTanenbaum JacobTanenbaum mentioned this issue Jan 4, 2018
Merged
openshift-merge-robot added a commit that referenced this issue Jan 8, 2018
@openshift-merge-robot
Merge pull request #17989 from JacobTanenbaum/flake17924
9425ace 
Automatic merge from submit-queue (batch tested with PRs 17899, 17726, 17989).

Fix the setup of the TestRouter

go1.8 is strict on requiring EOL in certs https://golang.org/doc/go1.8#encoding_pem

Fixes Flake: [17924](#17924)
@pravisankar
Copy link

Fixed by #17989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knobunc knobunc

Labels
component/networking kind/test-flake Categorizes issue or PR as related to test flakes. priority/P0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sjenning @soltysh @pravisankar @enj @stevekuznetsov @knobunc @tnozicka