Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --push-secret option to oc new-build for when using --to-docker --to with registry requiring auth. #17941

Closed
GrahamDumpleton opened this issue Dec 28, 2017 · 0 comments · Fixed by #18477

Comments

@GrahamDumpleton
Copy link

The oc new-build option allows you to specify --to-docker and --to to have resulting build pushed to a remote image registry, but it doesn't seem to be possible to specify a push secret at the same time, which means it isn't possible in one step to do this for a remote image registry which requires authentication.

Since pushing to a remote registry such as DockerHub would always require specifying a pushSecret, would make sense to make it easier by accepting a --push-secret option to oc new-build.

An alternative is to allow an annotation to be added to the secret so that it is automatically matched against a build configuration when a push secret is required. That is, similar to how one can specify an annotation on a secret with private Git repository credentials so they are automatically used. Am not aware of any annotation which currently does that.

openshift-merge-robot added a commit that referenced this issue Feb 8, 2018
Automatic merge from submit-queue.

Issue 17941: Add oc new-build --push-secret option

Adds a `--push-secret` option to `oc new-build` as requested in #17941

fixes #17941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants