-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sig-storage] HostPath should support existing directory subPath flake #18823
Comments
This isn't flaking. It is 100% failures |
100% failures after March 4 midnight https://deck-ci.svc.ci.openshift.org/?job=test_pull_request_origin_extended_conformance_gce |
https://deck-ci.svc.ci.openshift.org/?job=test_branch_origin_extended_conformance_gce indicates that 3.9 is also affected. This must be related to infrastructure or job definition. The 3.9 commit has nothing to do with this area. |
the failure does not appear contianer runtime related... the pod does not appear to ever schedule due to failing match node selectors.
@aveshagarwal -- can you dig deeper on this? |
@derekwaynecarr sure looking. |
The node where this pod is being scheduled has infra label: map[string]string{beta.kubernetes.io/arch: amd64,beta.kubernetes.io/instance-type: n1-standard-2,beta.kubernetes.io/os: linux,failure-domain.beta.kubernetes.io/region: us-east1,failure-domain.beta.kubernetes.io/zone: us-east1-c,kubernetes.io/hostname: ci-prtest-5a37c28-17025-ig-m-hdt0,node-role.kubernetes.io/infra: true,node-role.kubernetes.io/master: true,role: infra, Is it expected this test pod to get scheduled on the infra node? Or the test is incorrectly selecting infra node? Still checking what is going on if the above is really the issue. |
working on an upstream pr to fix the test to let the scheduler schedule the pod rather than self scheduling. this would let it work fine with any admission controllers running. |
hmm, of course, this change is not as trivial given the test structure. the test self-schedules pods, but prior to the pod actually being scheduled or run, it creates a directory on the machine it intends to run the pod against to validate that the pod sees that subdir. as a result, changing the test is non-obvious... |
simpler option for now is to disable namespace node selecting for upstream tests. see: https://github.com/openshift/origin/blob/master/test/extended/util/test.go#L231-L234 given how frequently this clause is used that would probably work best until we can change upstream. |
Just for reference, #18816 should address this. |
Automatic merge from submit-queue. Allow all node scheduling for more tests fixes #18823 need to take a pass at all tests that are self-scheduling to see if we need to open this list more.
https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/batch/test_pull_request_origin_extended_conformance_gce/17025/
@openshift/sig-storage
/kind test-flake
The text was updated successfully, but these errors were encountered: