TestVSphereLoginByToken data race

[sjenning]

This is a new test as of kube 1.11

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20158/pull-ci-origin-unit/900/

=== RUN   TestVSphereLoginByToken
E0705 17:13:06.921738    9479 connection.go:134] Logout failed: Post https://127.0.0.1:36902/sdk: dial tcp 127.0.0.1:36902: connect: connection refused
==================
WARNING: DATA RACE
Write at 0x00c4200fbbc0 by goroutine 48:
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/cloudprovider/providers/vsphere/vclib.(*VSphereConnection).Connect()
      /go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/cloudprovider/providers/vsphere/vclib/connection.go:59 +0x3ff
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/cloudprovider/providers/vsphere.TestVSphereLoginByToken()
      /go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/cloudprovider/providers/vsphere/vsphere_test.go:246 +0x335
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:777 +0x16d

Previous read at 0x00c4200fbbc0 by goroutine 5:
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/cloudprovider/providers/vsphere.logout()
      /go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/cloudprovider/providers/vsphere/vsphere.go:496 +0x13b

Goroutine 48 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:824 +0x564
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1063 +0xa4
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:777 +0x16d
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1061 +0x4e1
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:978 +0x2cd
  main.main()
      _testmain.go:112 +0x324

Goroutine 5 (running) created at:
  runtime.createfing()
      /usr/local/go/src/runtime/mfinal.go:156 +0x61
  os.NewFile()
      /usr/local/go/src/os/file_unix.go:79 +0x55
  os.init()
      /usr/local/go/src/os/file.go:58 +0x418
  main.init()
      <autogenerated>:1 +0x96
==================
--- FAIL: TestVSphereLoginByToken (0.31s)
	testing.go:730: race detected during execution of test

@smarterclayton

[sjenning]

added here kubernetes/kubernetes#63824

[sjenning]

looks like all tests share a VSphereInstance so running them in parallel could cause this

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci-robot]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.