Unable to edit image

[smarterclayton]

Try editing an image

$ oc edit image <SHA>

When you change something, you get

A copy of your changes has been stored to "/var/folders/zw/j6656mbn1rv4fnqqdggss8h80000gn/T/oc-edit-aeu4l.yaml"
error: unable to find api field in struct RawExtension for the json field "ContainerConfig"

which comes from LookupPatchMeta trying to traverse down into the Image field (which is an opaque blob).

We should fix this, because it could also apply to other types in the future.

[smarterclayton]

@Kargakis @fabianofranz this is an example of where strategic merge patch can't work in some of our objects.

[0xmichalis]

Not a P1 though

[smarterclayton]

Depends - can I edit templates? Or are those broken as wel.

[smarterclayton]

Also policy rules (not sure which other ones are involved).

[0xmichalis]

Depends - can I edit templates? Or are those broken as wel.

Just tested and editing a template works fine.

[smarterclayton]

It's really disturbing that this fails then. Agree its not p1

On Thu, Jun 9, 2016 at 10:36 AM, Michail Kargakis [email protected]
wrote:

Depends - can I edit templates? Or are those broken as wel.

Just tested and editing a template works fine.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#9232 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABG_p1OYX2jYPM2AHZ-xuEwY4ruEsmxXks5qKCT5gaJpZM4IxWXk
.

[0xmichalis]

Moving to @fabianofranz since I won't get to it any time soon

[jkaurredhat]

This also fails for annotate :

while editing image,
oc annotate --overwrite image sha256:c48070e4d8ec99d81170664aa8938dc2152e3c2fe4297bc511131e24f3ad6489 images.openshift.io/deny-execution=false

i get error:
Error from server: unable to find api field in struct RawExtension for the json field "Parent" or
Error from server: unable to find api field in struct RawExtension for the json field "Id" or
Error from server: unable to find api field in struct RawExtension for the json field "config"

OCP 3.4

[smarterclayton]

Annotate failing is a pretty high priority.

[mfojtik]

@smarterclayton i cannot reproduce this on the latest master (guess it was fixed?). Is this 3.4 only?

[mfojtik]

@smarterclayton @Kargakis @soltysh seems like we need to backport #12731 to 3.4?

[soltysh]

I'm closing this, since master has the fix in #12731 and 3.4 as well.