update PSP review APIs to take PodTemplateSpec #10007
Conversation
| // If ServiceAccountNames is specified, PodSpec.ServiceAccountName is ignored. | ||
| PodSpec kapi.PodSpec | ||
| // If ServiceAccountNames is specified, PodTemplateSpec.Spec.ServiceAccountName is ignored. | ||
| Template kapi.PodTemplateSpec |
There was a problem hiding this comment.
@smarterclayton confirm the name change.
There was a problem hiding this comment.
Name change confirmed. If ServiceAccountNames nil vs specified? Or empty is allowed?
There was a problem hiding this comment.
Hold this for protobuf
There was a problem hiding this comment.
Name change confirmed. If ServiceAccountNames nil vs specified? Or empty is allowed?
No difference between nil and empty. Also, no change here.
|
Simple rename. Approved above. [merge] |
|
[Test]ing while waiting on the merge queue |
|
Probably need to regen proto? On Mon, Jul 25, 2016 at 2:21 PM, David Eads [email protected]
|
|
Nm you did |
|
[test] #9959 On Mon, Jul 25, 2016 at 3:50 PM, OpenShift Bot [email protected]
|
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6972/) (Image: devenv-rhel7_4682) |
|
Evaluated for origin test up to e088398 |
|
Evaluated for origin merge up to e088398 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6972/) |
Fixes #9913