Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default image version for 'oc cluster up' #10022

Merged
merged 1 commit into from
Jul 27, 2016

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Jul 25, 2016

Sets the default value of the --version flag to the last released version that corresponds to the oc client.

@csrwng
Copy link
Contributor Author

csrwng commented Jul 25, 2016

@bparees ptal

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@csrwng csrwng force-pushed the clusterup_default_version branch from edf2642 to 68b6c7e Compare July 25, 2016 20:46
@csrwng
Copy link
Contributor Author

csrwng commented Jul 25, 2016

docs needed to be re-generated
[test]

@csrwng
Copy link
Contributor Author

csrwng commented Jul 26, 2016

test flake #10002
[test]

@csrwng csrwng force-pushed the clusterup_default_version branch from 68b6c7e to 091728a Compare July 26, 2016 21:29
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 27, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7004/) (Image: devenv-rhel7_4686)

@csrwng csrwng force-pushed the clusterup_default_version branch from 091728a to ea7f204 Compare July 27, 2016 13:54
@csrwng
Copy link
Contributor Author

csrwng commented Jul 27, 2016

@bparees ptal again, removed the default version from the flag declaration so it won't make it into the docs.

@bparees
Copy link
Contributor

bparees commented Jul 27, 2016

lgtm

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to ea7f204

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6982/)

@csrwng
Copy link
Contributor Author

csrwng commented Jul 27, 2016

flake #9959
[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to ea7f204

@openshift-bot openshift-bot merged commit 8faaa47 into openshift:master Jul 27, 2016
@csrwng csrwng deleted the clusterup_default_version branch December 21, 2016 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants