Allows filtering templates by namespace in new-app #10026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
| return ref, nil | ||
| } | ||
|
|
||
| func (r TemplateReference) WithNamespace() bool { |
There was a problem hiding this comment.
s/WithNamespace/HasNamespace/ ?
|
2 nits and lgtm |
fabianofranz
force-pushed
the
bugs_1248362
branch
from
65b02e1 to
e822fc3
Compare
|
Comments addressed, [merge]. |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6958/) (Image: devenv-rhel7_4676) |
fabianofranz
force-pushed
the
bugs_1248362
branch
from
e822fc3 to
243be94
Compare
fabianofranz
force-pushed
the
bugs_1248362
branch
from
243be94 to
0f6a3e0
Compare
|
Evaluated for origin test up to 0f6a3e0 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6923/) |
|
Evaluated for origin merge up to 0f6a3e0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1248362
This allows the use of the
namespace/templatenameform when specifying templates innew-app(it was already supported for image streams, but templates was lacking the support).So for example if you have templates with the exact same name "jenkins" in both "mynamespace" and "openshift", you can be explicit about which one you want to use with