Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildSource: mark secrets field as omitempty #10038

Merged
merged 1 commit into from
Jul 27, 2016

Conversation

php-coder
Copy link
Contributor

Prior this change secrets field was always serialized and was shown in build logs and available to assemble scripts as part of BUILD variable. I don't see a reason why we need to serialize it and print as "secrets":null.

PTAL @bparees

@bparees
Copy link
Contributor

bparees commented Jul 26, 2016

lgtm [merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 26, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6969/) (Image: devenv-rhel7_4682)

@bparees
Copy link
Contributor

bparees commented Jul 26, 2016

FAILURE: Swagger spec is out of date. Please run hack/update-generated-swagger-spec.sh

@php-coder php-coder force-pushed the omit_empty_secrets branch from 6fbfc24 to 7f52ce2 Compare July 27, 2016 09:45
@php-coder
Copy link
Contributor Author

Ah, I'm sorry. Should be fixed now.

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 7f52ce2

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6969/)

@bparees
Copy link
Contributor

bparees commented Jul 27, 2016

[merge]

Ben Parees | OpenShift

On Jul 27, 2016 7:05 AM, "OpenShift Bot" [email protected] wrote:

continuous-integration/openshift-jenkins/test SUCCESS (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6969/)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10038 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvl3qUyh-lAZN3lLerFoKAphY9M5YCaks5qZztwgaJpZM4JVIdq
.

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 7f52ce2

@openshift-bot openshift-bot merged commit 3378ee5 into openshift:master Jul 27, 2016
@php-coder php-coder deleted the omit_empty_secrets branch July 27, 2016 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants