Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new-app: accept template on stdin #10149

Merged
merged 1 commit into from
Aug 2, 2016

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Aug 1, 2016

new-app should not throw an error when passing a template on stdin
it currently breaks because isSingle is returned as false by the builder, even though there is only a single object in the list.

Fixes #8555

@csrwng
Copy link
Contributor Author

csrwng commented Aug 1, 2016

@bparees ptal

@bparees
Copy link
Contributor

bparees commented Aug 1, 2016

why is there a list at all? isn't it a single template?

@csrwng
Copy link
Contributor Author

csrwng commented Aug 2, 2016

why is there a list at all? isn't it a single template?

because if the input is a stream, the resource builder will put whatever it reads into a list and always sets isSingular to false:
https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/kubectl/resource/builder.go#L669

@bparees
Copy link
Contributor

bparees commented Aug 2, 2016

ok, thanks... lgtm
[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 2, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7352/) (Image: devenv-rhel7_4724)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to ac5405c

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to ac5405c

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7352/)

openshift-bot pushed a commit that referenced this pull request Aug 2, 2016
@openshift-bot openshift-bot merged commit 4c2094d into openshift:master Aug 2, 2016
@openshift-bot openshift-bot merged commit ac5405c into openshift:master Aug 2, 2016
@csrwng csrwng deleted the newapp_stdin_template branch December 21, 2016 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants