-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new-app: accept template on stdin #10149
Conversation
@bparees ptal |
why is there a list at all? isn't it a single template? |
because if the input is a stream, the resource builder will put whatever it reads into a list and always sets isSingular to false: |
ok, thanks... lgtm |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7352/) (Image: devenv-rhel7_4724) |
Evaluated for origin merge up to ac5405c |
[Test]ing while waiting on the merge queue |
Evaluated for origin test up to ac5405c |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7352/) |
new-app should not throw an error when passing a template on stdin
it currently breaks because isSingle is returned as false by the builder, even though there is only a single object in the list.
Fixes #8555