Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle container terminated but pod still running in conditions #10175

Merged
merged 2 commits into from
Aug 3, 2016

Conversation

fabianofranz
Copy link
Member

@fabianofranz fabianofranz commented Aug 2, 2016

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1360626
Upstream kubernetes/kubernetes#29952

Sometimes when you have a pod with more than one container, and the container runs and terminates really fast, PodContainerRunning can go into a state where the pod indicates it's still running, but the container is already terminated so oc debug never returns until it times out.

Handle that condition by returning ErrContainerTerminated when it happens.

@fabianofranz fabianofranz changed the title Bugs 1360626 Handle container terminated but pod still running in conditions Aug 2, 2016
@fabianofranz
Copy link
Member Author

@smarterclayton @ncdc PTAL

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to afb2b3a

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7419/)

@smarterclayton
Copy link
Contributor

LGTM [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 3, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7419/) (Image: devenv-rhel7_4747)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to afb2b3a

@openshift-bot openshift-bot merged commit a75133f into openshift:master Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants