UPSTREAM: 30162: return err on oc run --image with invalid value
#10250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| os::log::stacktrace::install | ||
| trap os::test::junit::reconcile_output EXIT | ||
|
|
||
| # Cleanup cluster resources created by this test |
There was a problem hiding this comment.
only add this if you need it
|
[test] |
juanvallejo
force-pushed
the
jvallejo_err-oc-run-on-invalid-image
branch
from
5de2606 to
e072f55
Compare
juanvallejo
changed the title
oc run --image with invalid value
juanvallejo
force-pushed
the
jvallejo_err-oc-run-on-invalid-image
branch
from
e072f55 to
e5a882f
Compare
|
@ncdc PTAL |
ncdc
changed the title
oc run --image with invalid valueoc run --image with invalid value
|
Do not merge until the upstream has merged |
juanvallejo
force-pushed
the
jvallejo_err-oc-run-on-invalid-image
branch
2 times, most recently
from
b5de697 to
2c30345
Compare
|
flake re[test] |
1 similar comment
|
flake re[test] |
ncdc
changed the title
oc run --image with invalid valueoc run --image with invalid value
juanvallejo
force-pushed
the
jvallejo_err-oc-run-on-invalid-image
branch
from
2c30345 to
be9e8ea
Compare
|
@openshift-bot, the last build failed from the following flakes:
re[test] |
|
Evaluated for origin test up to be9e8ea |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7736/) |
|
ncdc
changed the title
oc run --image with invalid valueoc run --image with invalid value
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7736/) (Image: devenv-rhel7_4813) |
|
Evaluated for origin merge up to be9e8ea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1258354
UPSTREAM: kubernetes/kubernetes#30162
When running
oc run <buildconfigname> --image="Invalid$$%ImageValue%%__", a deploymentconfig is successfully created with an image name that is not a valid value for an image reference.This patch validates that the image name is a valid image reference, and returns an error before creating a deployment config if an invalid value is passed.
$ oc run test --image="Invalid__%imagename"cc @fabianofranz