UPSTREAM: 30313: remove duplicate errors from aggregate error outputs #10317

juanvallejo · 2016-08-09T22:09:12Z

Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1257800
UPSTREAM: kubernetes/kubernetes#30313

Duplicate error messages are sometimes shown when displaying aggregate
errors:

$ oc label pod/database-1-fn0r7 qwer1345%$$#=self

* metadata.labels: Invalid value: "qwer1345%5602#": name part must match
* the regex ([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9] (e.g. 'MyName' or
* 'my.name' or '123-abc')
* metadata.labels: Invalid value: "qwer1345%5602#": name part must match
* the regex ([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9] (e.g. 'MyName' or
* 'my.name' or '123-abc')
* metadata.labels: Invalid value: "qwer1345%5602#": name part must match
* the regex ([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9] (e.g. 'MyName' or
* 'my.name' or '123-abc')

This patch removes any duplicate messages (adjacent or not) that appear
in the final list of errors.

Before

$ oc label pod/database-1-fn0r7 qwer1345%$$#=self

The Pod "database-1-fn0r7" is invalid.

* metadata.labels: Invalid value: "qwer1345%24704#": name part must match the regex ([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9] (e.g. 'MyName' or 'my.name' or '123-abc')
* metadata.labels: Invalid value: "qwer1345%24704#": name part must match the regex ([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9] (e.g. 'MyName' or 'my.name' or '123-abc')
* metadata.labels: Invalid value: "qwer1345%24704#": name part must match the regex ([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9] (e.g. 'MyName' or 'my.name' or '123-abc')
➜  origin git:(jvallejo_remove-duplicate-err-oclabel-ocenv) ✗ oc label pod/database-1-fn0r7 qwer1345%$$#=self

After

$ oc label pod/database-1-fn0r7 qwer1345%$$#=self

The Pod "database-1-fn0r7" is invalid.
metadata.labels: Invalid value: "qwer1345%24704#": name part must match the regex ([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9] (e.g. 'MyName' or 'my.name' or '123-abc')

cc @fabianofranz

juanvallejo · 2016-08-09T22:09:36Z

[test]

ncdc · 2016-08-10T11:07:54Z

Do not merge until upstream has merged

fabianofranz · 2016-08-12T15:51:03Z

LGTM if this only suppress a message if they are exactly equal when shown to the user. Sometimes we have a given error message shown multiple times to user (in oc new-app for example) but it takes the resource type/name as a prefix for the message. In that case, it still has to be shown.

error: DeploymentConfig "httpd" is invalid: [metadata.labels: Invalid value: "*(%$^$%": must match the regex (([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])? (e.g. 'MyValue' or 'my_value' or '12345'), spec.template.labels: Invalid value: "*(%$^$%": must match the regex (([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])? (e.g. 'MyValue' or 'my_value' or '12345')]
error: Service "httpd" is invalid: [metadata.labels: Invalid value: "*(%$^$%": must match the regex (([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])? (e.g. 'MyValue' or 'my_value' or '12345'), spec.selector: Invalid value: "*(%$^$%": must match the regex (([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])? (e.g. 'MyValue' or 'my_value' or '12345')]

liggitt · 2016-08-12T16:21:40Z

vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util/helpers.go

+		if errorMsgs.Has(sc.Message) {
+			continue
+		}
+		errorMsgs.Insert(sc.Message)
 		errs[i] = fmt.Errorf("%s: %s", sc.Field, sc.Message)


the duplicate check needs to include the field, since that's what the user sees

juanvallejo · 2016-08-12T16:21:50Z

@fabianofranz

Sometimes we have a given error message shown multiple times to user (in oc new-app for example) but it takes the resource type/name as a suffix for the message.

Yeah, this patch only suppresses parts of the error message that repear after <ResourceName> "x" is invalid:, as it was the metadata.labels part that was repeating.

liggitt · 2016-08-12T16:22:49Z

vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util/helpers.go

 	for i, sc := range scs {
+		// check for duplicate error messages and skip them
+		if errorMsgs.Has(sc.Message) {
+			continue


if we ever skip because of this, that means errs has nil errors interspersed, which I would expect to panic when NewAggregate attempts to call Error() on them

what you want to do is allocate errs with capacity of len(scs), but length 0, then use errs = append(errs, ...) instead of assigning directly to indexes

Good catch.

juanvallejo · 2016-08-12T21:49:31Z

@liggitt Thanks for the feedback!

what you want to do is allocate errs with capacity of len(scs), but length 0, then use errs = append(errs, ...) instead of assigning directly to indexes

Done!

juanvallejo · 2016-08-16T19:28:59Z

@openshift-bot, the last build failed from the following flakes:

make verify failed on: [travis] internal compiler error: schedule does not include all values #10445

re[test]

juanvallejo · 2016-08-22T14:11:49Z

@ncdc

Do not merge until upstream has merged

Done! kubernetes/kubernetes#30313

fabianofranz · 2016-08-22T15:06:37Z

@juanvallejo please remove [DO NOT MERGE] if this is good to go.
@liggitt anything else?

liggitt · 2016-08-22T15:08:15Z

one of the commits has a different line count than upstream... is it updated with the merged version from upstream? other than that, looks fine

juanvallejo · 2016-08-22T15:22:25Z

@liggitt

one of the commits has a different line count than upstream... is it updated with the merged version from upstream?

Yes, the changes for this commit and the one from upstream are the same. The files (without this patch) already have different line counts: origin, kubernetes

EDIT: I misunderstood your comment, there is an extra line-break in this commit: 5705847#diff-45d0049c1caf6801fde2ad4e6b3bb545R157

Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1257800 Duplicate error messages are sometimes shown when displaying aggregate errors: `$ oc label pod/database-1-fn0r7 qwer1345%$$#=self` ``` * metadata.labels: Invalid value: "qwer1345%5602#": name part must match * the regex ([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9] (e.g. 'MyName' or * 'my.name' or '123-abc') * metadata.labels: Invalid value: "qwer1345%5602#": name part must match * the regex ([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9] (e.g. 'MyName' or * 'my.name' or '123-abc') * metadata.labels: Invalid value: "qwer1345%5602#": name part must match * the regex ([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9] (e.g. 'MyName' or * 'my.name' or '123-abc') ``` This patch removes any duplicate messages (adjacent or not) that appear in the final list of errors.

fabianofranz · 2016-08-22T21:50:18Z

@juanvallejo I'd also like a negative kind of positive cmd test. :)

For example in test/cmd/newapp.sh, take the example below and make sure you still get every one of the 3 messages you are expected to get (one for each of ImageStream, DeploymentConfig, and Service).

$ $ oc new-app nginx -l qwer1345%$$#=self
(...)
    error: ImageStream "nginx" is invalid: metadata.labels: Invalid value: "qwer1345%25258#": name part must match (...)
    error: DeploymentConfig "nginx" is invalid: [metadata.labels: Invalid value: "qwer1345%25258#": name part must match (...)
    error: Service "nginx" is invalid: [metadata.labels: Invalid value: "qwer1345%25258#": name part must match (...)

juanvallejo · 2016-08-23T15:52:23Z

@fabianofranz
Done!

openshift-bot · 2016-08-23T15:52:27Z

Evaluated for origin test up to 29e7025

openshift-bot · 2016-08-23T17:15:58Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8364/)

fabianofranz · 2016-08-23T17:17:49Z

LGTM [merge]

openshift-bot · 2016-08-23T17:22:25Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8364/) (Image: devenv-rhel7_4907)

openshift-bot · 2016-08-23T17:22:26Z

Evaluated for origin merge up to 29e7025

Related PR: openshift/origin#10317 Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1257800#c3 PR kubernetes#10317 fixed duplicate errors for invalid aggregate errors in https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util/helpers.go. However, duplicate aggregate errors that went through https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/util/validation/field/errors.go were not affected by that patch. This patch adds duplicate aggregate error checking to `pkg/util/validation/field/errors.go` \##### Before `$ oc set env rc/idling-echo-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` `$ oc set env rc/node-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` \##### After `$ oc set env rc/idling-echo-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` `$ oc set env rc/node-1 test-abc=1234` ``` error: ReplicationController "node-1" is invalid: spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName" ``` :100644 100644 203f7cc... 089f21c... M pkg/util/validation/field/errors.go

Related PR: openshift#10317 Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1257800#c3 PR openshift#10317 fixed duplicate errors for invalid aggregate errors in https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util/helpers.go. However, duplicate aggregate errors that went through https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/util/validation/field/errors.go were not affected by that patch. This patch adds duplicate aggregate error checking to `pkg/util/validation/field/errors.go` \##### Before `$ oc set env rc/idling-echo-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` `$ oc set env rc/node-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` \##### After `$ oc set env rc/idling-echo-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` `$ oc set env rc/node-1 test-abc=1234` ``` error: ReplicationController "node-1" is invalid: spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName" ```

Related PR: openshift/origin#10317 Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1257800#c3 PR kubernetes#10317 fixed duplicate errors for invalid aggregate errors in https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util/helpers.go. However, duplicate aggregate errors that went through https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/util/validation/field/errors.go were not affected by that patch. This patch adds duplicate aggregate error checking to `pkg/util/validation/field/errors.go` \##### Before `$ oc set env rc/idling-echo-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` `$ oc set env rc/node-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` \##### After `$ oc set env rc/idling-echo-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` `$ oc set env rc/node-1 test-abc=1234` ``` error: ReplicationController "node-1" is invalid: spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName" ``` :100644 100644 203f7cc... 089f21c... M pkg/util/validation/field/errors.go

Related PR: openshift#10317 Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1257800#c3 PR openshift#10317 fixed duplicate errors for invalid aggregate errors in https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util/helpers.go. However, duplicate aggregate errors that went through https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/util/validation/field/errors.go were not affected by that patch. This patch adds duplicate aggregate error checking to `pkg/util/validation/field/errors.go` \##### Before `$ oc set env rc/idling-echo-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` `$ oc set env rc/node-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` \##### After `$ oc set env rc/idling-echo-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` `$ oc set env rc/node-1 test-abc=1234` ``` error: ReplicationController "node-1" is invalid: spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName" ```

Related PR: openshift/origin#10317 Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1257800#c3 PR kubernetes#10317 fixed duplicate errors for invalid aggregate errors in https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util/helpers.go. However, duplicate aggregate errors that went through https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/util/validation/field/errors.go were not affected by that patch. This patch adds duplicate aggregate error checking to `pkg/util/validation/field/errors.go` \##### Before `$ oc set env rc/idling-echo-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` `$ oc set env rc/node-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` \##### After `$ oc set env rc/idling-echo-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` `$ oc set env rc/node-1 test-abc=1234` ``` error: ReplicationController "node-1" is invalid: spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName" ``` :100644 100644 203f7cc... 089f21c... M pkg/util/validation/field/errors.go

ncdc changed the title ~~UPSTREAM: 30313: remove duplicate errors from aggregate error outputs~~ [DO NOT MERGE] UPSTREAM: 30313: remove duplicate errors from aggregate error outputs Aug 10, 2016

juanvallejo force-pushed the jvallejo_remove-duplicate-err-oclabel-ocenv branch from 1ba3bfd to d5d5046 Compare August 11, 2016 19:26

liggitt reviewed Aug 12, 2016
View reviewed changes

juanvallejo force-pushed the jvallejo_remove-duplicate-err-oclabel-ocenv branch from d5d5046 to a7fed0c Compare August 12, 2016 21:48

juanvallejo force-pushed the jvallejo_remove-duplicate-err-oclabel-ocenv branch 2 times, most recently from 15d970a to 7770899 Compare August 16, 2016 17:10

juanvallejo changed the title ~~[DO NOT MERGE] UPSTREAM: 30313: remove duplicate errors from aggregate error outputs~~ UPSTREAM: 30313: remove duplicate errors from aggregate error outputs Aug 22, 2016

juanvallejo added 2 commits August 22, 2016 11:49

UPSTREAM: 30313: add unit test for duplicate errors

2061aab

juanvallejo force-pushed the jvallejo_remove-duplicate-err-oclabel-ocenv branch from 7770899 to 2061aab Compare August 22, 2016 15:50

add test for non-duplicate error outputs

29e7025

openshift-bot merged commit 1605423 into openshift:master Aug 23, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UPSTREAM: 30313: remove duplicate errors from aggregate error outputs #10317

UPSTREAM: 30313: remove duplicate errors from aggregate error outputs #10317

juanvallejo commented Aug 9, 2016 •

edited

Loading

juanvallejo commented Aug 9, 2016

ncdc commented Aug 10, 2016

fabianofranz commented Aug 12, 2016 •

edited

Loading

liggitt Aug 12, 2016

juanvallejo commented Aug 12, 2016

liggitt Aug 12, 2016 •

edited

Loading

liggitt Aug 12, 2016

fabianofranz Aug 12, 2016

juanvallejo commented Aug 12, 2016

juanvallejo commented Aug 16, 2016

juanvallejo commented Aug 22, 2016 •

edited

Loading

fabianofranz commented Aug 22, 2016

liggitt commented Aug 22, 2016 •

edited

Loading

juanvallejo commented Aug 22, 2016 •

edited

Loading

fabianofranz commented Aug 22, 2016

juanvallejo commented Aug 23, 2016

openshift-bot commented Aug 23, 2016

openshift-bot commented Aug 23, 2016

fabianofranz commented Aug 23, 2016

openshift-bot commented Aug 23, 2016 •

edited

Loading

openshift-bot commented Aug 23, 2016

UPSTREAM: 30313: remove duplicate errors from aggregate error outputs #10317

UPSTREAM: 30313: remove duplicate errors from aggregate error outputs #10317

Conversation

juanvallejo commented Aug 9, 2016 • edited Loading

Before

After

juanvallejo commented Aug 9, 2016

ncdc commented Aug 10, 2016

fabianofranz commented Aug 12, 2016 • edited Loading

liggitt Aug 12, 2016

Choose a reason for hiding this comment

juanvallejo commented Aug 12, 2016

liggitt Aug 12, 2016 • edited Loading

Choose a reason for hiding this comment

liggitt Aug 12, 2016

Choose a reason for hiding this comment

fabianofranz Aug 12, 2016

Choose a reason for hiding this comment

juanvallejo commented Aug 12, 2016

juanvallejo commented Aug 16, 2016

juanvallejo commented Aug 22, 2016 • edited Loading

fabianofranz commented Aug 22, 2016

liggitt commented Aug 22, 2016 • edited Loading

juanvallejo commented Aug 22, 2016 • edited Loading

fabianofranz commented Aug 22, 2016

juanvallejo commented Aug 23, 2016

openshift-bot commented Aug 23, 2016

openshift-bot commented Aug 23, 2016

fabianofranz commented Aug 23, 2016

openshift-bot commented Aug 23, 2016 • edited Loading

openshift-bot commented Aug 23, 2016

juanvallejo commented Aug 9, 2016 •

edited

Loading

fabianofranz commented Aug 12, 2016 •

edited

Loading

liggitt Aug 12, 2016 •

edited

Loading

juanvallejo commented Aug 22, 2016 •

edited

Loading

liggitt commented Aug 22, 2016 •

edited

Loading

juanvallejo commented Aug 22, 2016 •

edited

Loading

openshift-bot commented Aug 23, 2016 •

edited

Loading