Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 27541: Attach init container #10427

Merged
merged 1 commit into from
Aug 18, 2016

Conversation

smarterclayton
Copy link
Contributor

It should be possible to attach to init containers.

Fixes bug https://bugzilla.redhat.com/show_bug.cgi?id=1364017

[test]

@smarterclayton
Copy link
Contributor Author

@fabianofranz @ncdc

@fabianofranz
Copy link
Member

LGTM

@ncdc
Copy link
Contributor

ncdc commented Aug 16, 2016

This doesn't match 28012. It's actually a partial cherry pick of 27541. Not sure which of those two you actually want, since 28012 changes the code added in 27541... ?

@smarterclayton smarterclayton force-pushed the attach_init branch 2 times, most recently from 29236b4 to 0f769c6 Compare August 17, 2016 16:43
@smarterclayton
Copy link
Contributor Author

Repicked

@ncdc ncdc changed the title UPSTREAM: 28012: Attach init container UPSTREAM: 27541: Attach init container Aug 17, 2016
@ncdc
Copy link
Contributor

ncdc commented Aug 17, 2016

LGTM [merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 14b69ec

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8076/)

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 17, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8076/) (Image: devenv-rhel7_4866)

@smarterclayton
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 14b69ec

@openshift-bot openshift-bot merged commit 81d5f92 into openshift:master Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants