support for zero weighted services in a route #10428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] again |
|
LGTM [test] |
| @@ -46,7 +46,7 @@ func ValidateRoute(route *routeapi.Route) field.ErrorList { | |||
| if route.Spec.To.Kind != "Service" { | |||
| result = append(result, field.Invalid(specPath.Child("to", "kind"), route.Spec.To.Kind, "must reference a Service")) | |||
| } | |||
| if route.Spec.To.Weight != nil && (*route.Spec.To.Weight < 1 || *route.Spec.To.Weight > 256) { | |||
| if route.Spec.To.Weight != nil && (*route.Spec.To.Weight < 0 || *route.Spec.To.Weight > 256) { | |||
| result = append(result, field.Invalid(specPath.Child("to", "weight"), route.Spec.To.Weight, "weight must be an integer between 1 and 256")) | |||
There was a problem hiding this comment.
Minor nit: error message still says 1-256.
|
@rajatchopra tests possibly are failing due to the check - use |
rajatchopra
force-pushed
the
zeroweights
branch
from
ec8f26a to
cb70609
Compare
openshift-bot
added
the
needs-rebase
rajatchopra
force-pushed
the
zeroweights
branch
3 times, most recently
from
b02d089 to
72af619
Compare
rajatchopra
force-pushed
the
zeroweights
branch
from
72af619 to
e7cd87e
Compare
openshift-bot
removed
the
needs-rebase
|
[test] again |
|
[test] |
|
Evaluated for origin test up to e7cd87e |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8040/) |
|
LGTM |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8040/) (Image: devenv-rhel7_4857) |
|
Evaluated for origin merge up to e7cd87e |
|
API change approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10279
Both 'to' and 'alternateBackends' can now point to a service with '0' as the weight. Any service with '0' weight will not have its servers listed as backends to the haproxy router. This means that one can disable a route completely by having all its services with a weight '0'. The config may still catch the request but with none of the backends existing it will result in a 503.
[test]