Fix validation of pkg/sdn/api object updates #10466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
[merge] |
|
[Test]ing while waiting on the merge queue |
|
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8050/ appears to be #9856 which was supposed to be fixed but apparently isn't. [merge] |
openshift-bot
added
the
needs-rebase
The code was assuming that the update validators automatically called the creation validator too, but that's apparently not how it works.
danwinship
force-pushed
the
sdn-update-validation
branch
from
093aee1 to
1e876fe
Compare
|
@pravisankar want to look at it again and re-merge? (since the rebase conflict was against your vnid PR) |
|
Evaluated for origin test up to 1e876fe |
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8086/) |
openshift-bot
removed
the
needs-rebase
|
Evaluated for origin merge up to 1e876fe |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8086/) (Image: devenv-rhel7_4864) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was assuming that the update validators automatically called the creation validator too, but that's apparently not how it works.
Closes https://bugzilla.redhat.com/show_bug.cgi?id=1367246
@openshift/networking PTAL