UPSTREAM: 28234: Make sure --record=false is acknowledged when passed to commands #10486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
@damemi rebase needed (FAILURE: Generated docs up to date, but generated man pages out of date. Please run hack/update-generated-docs.sh) |
|
@smarterclayton when can we get generated docs etc out of the repo? Rebasing for an error like this shouldn't be necessary. |
|
It's probably pretty far down the priority list. |
damemi
force-pushed
the
master
branch
3 times, most recently
from
5ee4a2d to
1e22565
Compare
|
Evaluated for origin test up to 1e22565 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8254/) |
|
@ncdc were you ok with this one merging? Tests are green. |
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8254/) (Image: devenv-rhel7_4907) |
|
Evaluated for origin merge up to 1e22565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of upstream commit:
Ensures that when --record=false is explicity set that no ChangeCauseAnnotations are set on the object. Previously, if --record=true was used then all following actions triggered a ChangeCauseAnnotation even if --record=false was set, due to the prior ChangeCauseAnnotation existing.
Reference to bug report: https://bugzilla.redhat.com/show_bug.cgi?id=1351127