Update build status to indicate build failure reason #10817

PI-Victor · 2016-09-06T13:48:31Z

trello: https://trello.com/c/nAPDRELK/852-5-update-build-status-to-indicate-build-failure-reason-evg

PI-Victor · 2016-09-06T13:51:30Z

bparees · 2016-09-06T17:09:57Z

pkg/build/api/types.go

@@ -266,6 +266,18 @@ const (
 	// secret for pushing the output image.
 	// The build will stay in the pending state until the secret is created, or the build times out.
 	StatusReasonMissingPushSecret = "MissingPushSecret"
+
+	// StatusReasonFailedPostCommitHook indicates that the postcommit failed


"indicates the post-commit hook failed"

comment shoudl say StatusReasonPostCommitHookFailed

PI-Victor · 2016-09-06T17:20:35Z

@mfojtik you said these errors should also end up in oc status, right?

bparees · 2016-09-06T17:23:07Z

pkg/build/registry/build/strategy.go

@@ -110,25 +112,39 @@ type detailsStrategy struct {

 // Prepares a build for update by only allowing an update to build details.
 // For now, this is the Spec.Revision field
+// We now need to update the build.status.Reason and build.Status.Message


// build details currently consists of: Spec.Revision, Status.Reason, and Status.Message, all of which are updated from within the build pod

mfojtik · 2016-09-06T17:24:14Z

@mfojtik you said these errors should also end up in oc status, right?

in future yes, that is how I'm thinking about these errors

bparees · 2016-09-06T17:29:20Z

pkg/build/registry/build/strategy.go

+	oldRevision := oldBuild.Spec.Revision
+	newRevision := newBuild.Spec.Revision
+	glog.V(0).Infof("newbuild: %#v", newRevision)
+	glog.V(0).Infof("oldBuild: %#v", oldRevision)


extraneous debugging?

yeah. thought i cleaned it up pretty noice, was wrong

PI-Victor · 2016-09-10T00:10:42Z

@csrwng thank you for the help, was able to figure it out in the end.

Miciah · 2016-09-10T06:28:31Z

pkg/build/builder/docker.go

+		glog.V(4).Infof("Setting build revision to %#v", d.build.Spec.Revision.Git)
+		updateBuildRevision(d.build, sourceInfo)
+		if _, err = d.client.UpdateDetails(d.build); err != nil {
+			glog.V(0).Infof("error: An error occure while updating the build revision")


s/occure/occured/

smarterclayton · 2016-11-18T18:13:02Z

Split the messages out into their own chunk and make a comment that they
are NOT guaranteed not to change

On Fri, Nov 18, 2016 at 9:00 AM, Ben Parees [email protected]
wrote:

@bparees commented on this pull request.

In pkg/build/api/types.go #10817
:

StatusMessagePushImageToRegistryFailed = "Failed to push the image to the registry"

// StatusReasonPullBuilderImageFailed indicates that we failed to pull the

// builder image.

StatusReasonPullBuilderImageFailed StatusReason = "PullBuilderImageFailed"

StatusMessagePullBuilderImageFailed = "Failed pulling builder image"
+

// StatusReasonFetchSourceFailed indicates that fetching the source of the

// build has failed.

StatusReasonFetchSourceFailed StatusReason = "FetchSourceFailed"

StatusMessageFetchSourceFailed = "Failed to fetch the input source"
+

// StatusReasonCancelledBuild indicates that the build was cancelled by the

// user.

StatusReasonCancelledBuild StatusReason = "CancelledBuild"

StatusMessageCancelledBuild = "The build was cancelled by the user"

this is the internal api file, not the public api..and there is precedence:
https://github.com/openshift/origin/blob/master/pkg/deploy/
api/types.go#L95-L100

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#10817, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p3VFTz6FcADmXpWSqpIvspeS1o6Kks5q_dmdgaJpZM4J121e
.

bparees · 2016-11-24T14:19:32Z

No. Create an issue. (but fix your instance of it in this pr of course) Ben Parees | OpenShift

…

On Nov 24, 2016 08:22, "Ionut Palade" ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pkg/build/builder/docker.go <#10817>: > if sourceInfo != nil { - updateBuildRevision(d.client, d.build, sourceInfo) + glog.V(4).Infof("Setting build revision with details %#v", sourceInfo) + revision := updateBuildRevision(d.build, sourceInfo) + if updateErr := updateStatusRetrier(d.build, d.client, revision); updateErr != nil { + glog.V(0).Infof("error: An error occured while updating the build status: %v", updateErr) @bparees <https://github.com/bparees> should i create a PR to handle the errors in the controller and build pods with runtime.HandleError? i see a lot of them are used without. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10817>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEvl3kT_6yp3DZ3dOWKDWjagIwOHWS5Cks5rBY9_gaJpZM4J121e> .

bparees · 2016-11-28T15:30:14Z

[testextended][extended:core(builds|image_ecosystem)]

bparees · 2016-11-28T16:51:28Z

@PI-Victor looks like some extended test compilation issues to work through:

[WARNING] No compiled `extended.test` binary was found. Attempting to build one using:
[WARNING]   $ hack/build-go.sh test/extended/extended.test
++ Building go targets for linux/amd64: test/extended/extended.test
# github.com/openshift/origin/test/extended/builds
test/extended/builds/failure_status.go:31: oc.KubeREST undefined (type *"github.com/openshift/origin/test/extended/util".CLI has no field or method KubeREST)
test/extended/builds/failure_status.go:44: oc.REST undefined (type *"github.com/openshift/origin/test/extended/util".CLI has no field or method REST)
test/extended/builds/failure_status.go:60: oc.REST undefined (type *"github.com/openshift/origin/test/extended/util".CLI has no field or method REST)
test/extended/builds/failure_status.go:76: oc.REST undefined (type *"github.com/openshift/origin/test/extended/util".CLI has no field or method REST)
test/extended/builds/failure_status.go:92: oc.REST undefined (type *"github.com/openshift/origin/test/extended/util".CLI has no field or method REST)
test/extended/builds/failure_status.go:108: oc.REST undefined (type *"github.com/openshift/origin/test/extended/util".CLI has no field or method REST)

PI-Victor · 2016-11-28T17:49:18Z

@bparees yes, seems that KubeRest was removed from there, looking into other test packages to see how to fix this.

mfojtik · 2016-11-28T21:47:41Z

@PI-Victor it is Client and KubeClient now.

PI-Victor · 2016-11-29T12:26:19Z

@mfojtik thanks.
tests for me are not passing locally because [insert reason here] so i want to see if they pass online. this was a working state PR the last time i ran extended tests on it :/

openshift-bot · 2016-11-29T19:06:52Z

continuous-integration/openshift-jenkins/test Waiting: Determining build queue position

openshift-bot · 2016-11-30T14:46:01Z

Evaluated for origin testextended up to 4b54d01

openshift-bot · 2016-11-30T14:46:10Z

Evaluated for origin test up to 4b54d01

openshift-bot · 2016-11-30T16:13:45Z

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11813/) (Base Commit: 44fc84b)

PI-Victor · 2016-11-30T16:16:12Z

flake #10663

openshift-bot · 2016-11-30T19:05:58Z

continuous-integration/openshift-jenkins/testextended FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/846/) (Base Commit: 74d945c) (Extended Tests: core(builds|image_ecosystem))

bparees · 2016-11-30T19:46:38Z

extended test failure is a known issue.
[merge]

PI-Victor · 2016-11-30T20:02:59Z

@bparees thanks! was hoping this will pass, i've fixed the tests and the one that was faulty.

bparees · 2016-12-01T02:09:44Z

yum repo issues.
[merge]

bparees · 2016-12-01T04:07:57Z

flake #10663
[merge]

openshift-bot · 2016-12-01T04:13:19Z

Evaluated for origin merge up to 4b54d01

openshift-bot · 2016-12-01T04:13:28Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11844/) (Base Commit: 166273b) (Image: devenv-rhel7_5453)

bparees reviewed Sep 6, 2016
View reviewed changes

PI-Victor force-pushed the update_build_status branch 2 times, most recently from b3a5c06 to eedd08a Compare September 8, 2016 14:19

Miciah reviewed Sep 10, 2016
View reviewed changes

PI-Victor force-pushed the update_build_status branch from 2dee18f to 4e94444 Compare November 23, 2016 12:07

PI-Victor mentioned this pull request Nov 24, 2016

errors should be sent to k8s util/HandleError #12020

Closed

PI-Victor force-pushed the update_build_status branch from 20dccbb to 4432145 Compare November 28, 2016 15:28

PI-Victor force-pushed the update_build_status branch from 4432145 to 6115352 Compare November 29, 2016 12:19

PI-Victor force-pushed the update_build_status branch 2 times, most recently from 2ea7681 to 7ab3371 Compare November 29, 2016 18:56

add failure reasons

4b54d01

PI-Victor force-pushed the update_build_status branch from 7ab3371 to 4b54d01 Compare November 30, 2016 14:43

openshift-bot merged commit 46f4630 into openshift:master Dec 1, 2016

mmilata mentioned this pull request Dec 1, 2016

Fail new builds that can't start build pod because it already exists #12057

Merged

PI-Victor deleted the update_build_status branch January 23, 2017 09:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update build status to indicate build failure reason #10817

Update build status to indicate build failure reason #10817

PI-Victor commented Sep 6, 2016

PI-Victor commented Sep 6, 2016

bparees Sep 6, 2016

bparees Sep 6, 2016

PI-Victor commented Sep 6, 2016

bparees Sep 6, 2016

mfojtik commented Sep 6, 2016

bparees Sep 6, 2016

PI-Victor Sep 6, 2016

PI-Victor commented Sep 10, 2016

Miciah Sep 10, 2016

smarterclayton commented Nov 18, 2016

@bparees commented on this pull request.

bparees commented Nov 24, 2016 via email

bparees commented Nov 28, 2016

bparees commented Nov 28, 2016

PI-Victor commented Nov 28, 2016

mfojtik commented Nov 28, 2016

PI-Victor commented Nov 29, 2016

openshift-bot commented Nov 29, 2016 •

edited

Loading

openshift-bot commented Nov 30, 2016

openshift-bot commented Nov 30, 2016

openshift-bot commented Nov 30, 2016

PI-Victor commented Nov 30, 2016

openshift-bot commented Nov 30, 2016

bparees commented Nov 30, 2016

PI-Victor commented Nov 30, 2016

bparees commented Dec 1, 2016

bparees commented Dec 1, 2016

openshift-bot commented Dec 1, 2016

openshift-bot commented Dec 1, 2016 •

edited

Loading

Update build status to indicate build failure reason #10817

Update build status to indicate build failure reason #10817

Conversation

PI-Victor commented Sep 6, 2016

PI-Victor commented Sep 6, 2016

bparees Sep 6, 2016

Choose a reason for hiding this comment

bparees Sep 6, 2016

Choose a reason for hiding this comment

PI-Victor commented Sep 6, 2016

bparees Sep 6, 2016

Choose a reason for hiding this comment

mfojtik commented Sep 6, 2016

bparees Sep 6, 2016

Choose a reason for hiding this comment

PI-Victor Sep 6, 2016

Choose a reason for hiding this comment

PI-Victor commented Sep 10, 2016

Miciah Sep 10, 2016

Choose a reason for hiding this comment

smarterclayton commented Nov 18, 2016

@bparees commented on this pull request.

bparees commented Nov 24, 2016 via email

bparees commented Nov 28, 2016

bparees commented Nov 28, 2016

PI-Victor commented Nov 28, 2016

mfojtik commented Nov 28, 2016

PI-Victor commented Nov 29, 2016

openshift-bot commented Nov 29, 2016 • edited Loading

openshift-bot commented Nov 30, 2016

openshift-bot commented Nov 30, 2016

openshift-bot commented Nov 30, 2016

PI-Victor commented Nov 30, 2016

openshift-bot commented Nov 30, 2016

bparees commented Nov 30, 2016

PI-Victor commented Nov 30, 2016

bparees commented Dec 1, 2016

bparees commented Dec 1, 2016

openshift-bot commented Dec 1, 2016

openshift-bot commented Dec 1, 2016 • edited Loading

openshift-bot commented Nov 29, 2016 •

edited

Loading

openshift-bot commented Dec 1, 2016 •

edited

Loading