Remove --credentials flags, stop generating router/registry client certs #10830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
openshift-bot
added
the
needs-rebase
|
Do we have an ETA on when this will be cherry picked into OpenShift Enterprise 3.x? Then I'll attach CVE-2015-8945 to the errata in question and we can close this out. |
openshift-bot
added
needs-rebase
openshift-bot
added
needs-rebase
liggitt
changed the title
|
[test] |
liggitt
changed the title
openshift-bot
removed
the
needs-rebase
|
I don't see any problems with this and our current installer code. |
openshift-bot
added
the
needs-rebase
openshift-bot
removed
the
needs-rebase
deads2k
reviewed
Jan 24, 2017
| } | ||
|
|
||
| needServiceAccountRole := len(opts.Config.ServiceAccount) > 0 && len(opts.Config.Credentials) == 0 | ||
| needServiceAccountRole := len(opts.Config.ServiceAccount) > 0 |
There was a problem hiding this comment.
Didn't you just make sure they specified it? this bool seems unnecessary.
deads2k
reviewed
Jan 24, 2017
| } | ||
| createServiceAccount := len(cfg.ServiceAccount) > 0 && len(cfg.Credentials) == 0 | ||
| createServiceAccount := len(cfg.ServiceAccount) > 0 |
|
minor comments. lgtm otherwise. |
|
[merge] |
|
Evaluated for origin test up to 9a86874 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13275/) (Base Commit: ed6d1ad) |
|
Evaluated for origin merge up to 9a86874 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13292/) (Base Commit: a32dda3) (Image: devenv-rhel7_5774) |
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
Mar 18, 2017
This is primarily to get the signature access docker/distribution API extension. To make it work, two updates to the test harness are necessary: - Change the expected output of (oadm policy add-cluster-role-to-group) - Don't expect (openshift start master) to create .kubeconfig files for the registry service. As of openshift/origin#10830 , openshift.local.config/master/openshift-registry.kubeconfig is no longer autogenerated. Instead, do what (oadm registry) does, creating a service account and a cluster policy role binding. Then manually create the necessary certificates and a .kubeconfig instead of using the service account in a pod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3951
doc in openshift/openshift-docs#3552
ansible hasn't used this since 3.2