Add service account for attach-detach controller #10892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Rules: []authorizationapi.PolicyRule{ | ||
| // shared informer on PVs | ||
| { | ||
| Verbs: sets.NewString("list", "watch"), |
There was a problem hiding this comment.
do we need get on any of the list/watch resources?
There was a problem hiding this comment.
we need it on nodes, which is accounted for.
|
questions on a couple permissions, test fixture update needed, LGTM otherwise |
pmorie
force-pushed
the
attach-detach-sa
branch
from
228a17b to
d3c7021
Compare
|
@liggitt light is green and in-situ test checked out, i can haz merge? |
|
Is this 1.3.0? |
| @@ -44,6 +44,9 @@ const ( | |||
| InfraPersistentVolumeBinderControllerServiceAccountName = "pv-binder-controller" | |||
| PersistentVolumeBinderControllerRoleName = "system:pv-binder-controller" | |||
|
|
|||
| InfraAttachDetachControllerServiceAccountName = "attach-detach-controller" | |||
There was a problem hiding this comment.
Do we want this named "pv-…" for consistency with the others?
There was a problem hiding this comment.
I'm cool with that, I'll rename tonight.
|
yep |
pmorie
force-pushed
the
attach-detach-sa
branch
from
d3c7021 to
dd1ce84
Compare
|
LGTM, [merge] |
|
Evaluated for origin merge up to dd1ce84 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8851/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a service account for the attach-detach controller.