Allow annotation selector to match annotation values #10896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @deads2k |
|
LGTM but want david's sign off. Will move to 1.3.0 before i cut the release. |
|
[test] |
| if err != nil { | ||
| return nil, err | ||
| } | ||
| annotationSelector = selector.AnnotationSelector |
There was a problem hiding this comment.
Do we need to make a copy of the map here?
There was a problem hiding this comment.
Probably to be safe.
|
Evaluated for origin test up to 1575920 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8844/) |
|
lgtm |
|
[merge] |
|
Evaluated for origin merge up to 1575920 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8849/) (Image: devenv-rhel7_5011) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes server-side matching for #10877
CLI specification of annotation selector still needs fixing