Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop EgressNetworkPolicy 1.2->1.3 upgrade code #11073

Merged
merged 1 commit into from
Sep 28, 2016
Merged

Drop EgressNetworkPolicy 1.2->1.3 upgrade code #11073

merged 1 commit into from
Sep 28, 2016

Conversation

danwinship
Copy link
Contributor

This drops the code we added to warn people about doing reconcile-cluster-roles after a 1.2->1.3 upgrade, as per discussion in #10358.

Closes #10413

@openshift/networking PTAL

knobunc
knobunc reviewed Sep 23, 2016
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't see what requests the removal (over in that thread)

pecameron
pecameron approved these changes Sep 23, 2016
View reviewed changes
Copy link
Contributor

@pecameron pecameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems strange that anyone would want to do this...

@danwinship
Copy link
Contributor Author

LGTM, but I don't see what requests the removal (over in that thread)

#10358 (comment):

can you also add a comment here explaining what server version this is maintaining compatibility for, and open a follow-up techdebt issue to track removing this in a future release?

@dcbw
Copy link
Contributor

dcbw commented Sep 23, 2016

LGTM; though what are the timelines here? eg, backwards compat will be dropped for 3.4 because we expect everyone updating to 3.4 to have already updated to 3.3? Does OpenShift support eg 3.2 -> 3.4 updates?

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2016
@danwinship
Revert "Allow startup to continue even if nodes don't have EgressNetw…
19ba6a4 
…orkPolicy list permission"

This was useful for 1.2->1.3 upgrades but we don't want the code there
forever.

This reverts commit 6252e95.
@danwinship danwinship force-pushed the drop-egressnetworkpolicy-upgrade branch from d13481c to 19ba6a4 Compare September 28, 2016 17:36
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2016
@dcbw
Copy link
Contributor

dcbw commented Sep 28, 2016

Specific comment saying we should remove this for 3.4 is #10358 (comment) so if David thinks it's OK, I'm OK too.

@dcbw
Copy link
Contributor

dcbw commented Sep 28, 2016

[merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 19ba6a4

@pravisankar
Copy link

snippet from https://docs.openshift.com/enterprise/3.2/install_config/upgrading/manual_upgrades.html
"Cluster upgrades cannot span more than one minor version at a time, so if your cluster is at version 3.0 or 3.1, you must first upgrade incrementally (e.g., 3.0 to 3.1, then 3.1 or 3.2)"
So we don't support openshift 3.2 --> 3.4 update.
LGTM

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9436/)

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 28, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9436/) (Image: devenv-rhel7_5095)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 19ba6a4

@openshift-bot openshift-bot merged commit e6bdecf into openshift:master Sep 28, 2016
@danwinship danwinship deleted the drop-egressnetworkpolicy-upgrade branch September 29, 2016 12:34
@pravisankar pravisankar mentioned this pull request Nov 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc knobunc left review comments

@pecameron pecameron pecameron approved these changes

Assignees
No one assigned
Labels
component/networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danwinship @dcbw @openshift-bot @pravisankar @knobunc @pecameron