Update to start-build --follow, somewhat contradicting #6268 #11119
Conversation
jim-minter
force-pushed
the
bz1368581
branch
2 times, most recently
from
edf12d2 to
199e700
Compare
| if err != nil { | ||
| // retry the connection to build logs when we hit the timeout. | ||
| if oerrors.IsTimeoutErr(err) { | ||
| continue |
There was a problem hiding this comment.
we should print a message to the user each time we timeout and start waiting again, so they know we're still waiting for the build to start/logs to start.
There was a problem hiding this comment.
@bparees, done, ready to go if you're happy with it.
- make --follow always retry on timeouts - make --follow imply --wait: guarantee returning an error, or ensure stream has finished and build status is in complete, failed, cancelled, error (aka not new, pending, running) - remove possible undesirable race condition (I think --follow --wait could unwittingly truncate returned logs)
jim-minter
force-pushed
the
bz1368581
branch
from
199e700 to
335e1c3
Compare
|
lgtm |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 335e1c3 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9359/) |
|
looks like it failed due to a network glitch - couldn't connect to github.com:443 |
|
flake #11016 [merge] |
|
Evaluated for origin merge up to 335e1c3 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9467/) (Image: devenv-rhel7_5099) |
has finished and build status is in complete, failed, cancelled,
error (aka not new, pending, running)
could unwittingly truncate returned logs)