rules review endpoint for other user #11172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deads2k see the last three commits and feel free to cherry-pick to your branch or merge this ;-) |
|
[test] |
|
lgtm. free to merge on green |
|
@deads2k can you check on your laptop the protobuf files? for some reason travis reports they are wrong |
mfojtik
force-pushed
the
deads-rules-review
branch
2 times, most recently
from
1bf146c to
d296e70
Compare
|
[test] |
openshift-bot
added
the
needs-rebase
mfojtik
force-pushed
the
deads-rules-review
branch
from
d296e70 to
530d3a1
Compare
openshift-bot
removed
the
needs-rebase
|
[test] |
|
Evaluated for origin test up to 530d3a1 |
|
@deads2k I think this is now good to merge (the flake was device mapper in conformance, the other tests passed). |
|
[merge] |
|
Evaluated for origin merge up to 530d3a1 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9609/) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9626/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #10611