Enable extended validation check on all routes admitted in by the router. #11218
Conversation
…ter. Update generated docs/manpage
|
[test] |
|
Evaluated for origin test up to b5c87b9 |
|
Is status written back to the route if the cert is invalid? Did we consider adding this validation to the route API? |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9642/) |
|
Yes, the status is written back on invalid config/rejections etc. The issue with adding to the route API is that we could potentially break existing routes in etcd. Since we wanted to backport this, wouldn't it be more prudent to do this on admission into the router? |
|
@liggitt do you have any other comments on this or is it good to merge? Thx |
|
this looks fine. ideally, we would eventually add validation in the API anyway, to prevent all routers from having to implement this themselves (and work through the churn of continually rejecting routes with invalid certs) |
|
[merge] |
|
Flake #8571 [merge] |
|
Evaluated for origin merge up to b5c87b9 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9987/) (Base Commit: 2cd1700) (Image: devenv-rhel7_5167) |
Enabled extended validation check on all routes admitted in by the router and update generated docs/manpage.
@liggitt PTAL Thx