Clarify new-app messages #11220
Merged
Clarify new-app messages #11220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csrwng
reviewed
Oct 11, 2016
| if len(meta.Namespace) == 0 || namespace == meta.Namespace { | ||
| return meta.Name | ||
| if len(meta.Namespace) == 0 { | ||
| return fmt.Sprintf(`"%s"`, meta.Name) |
There was a problem hiding this comment.
just return the string without the quotes
| } | ||
| return fmt.Sprintf("%q in project %q", meta.Name, meta.Namespace) | ||
| return fmt.Sprintf(`"%s/%s"`, meta.Namespace, meta.Name) |
| } else { | ||
| fmt.Fprintf(out, "--> Deploying template %s\n", qualifiedName) | ||
| fmt.Fprintf(out, "--> Deploying template %s to project %s\n", qualifiedName, baseNamespace) |
| @@ -50,9 +50,9 @@ func TransformTemplate(tpl *templateapi.Template, client client.TemplateConfigsN | |||
| func DescribeGeneratedTemplate(out io.Writer, input string, result *templateapi.Template, baseNamespace string) { | |||
| qualifiedName := localOrRemoteName(result.ObjectMeta, baseNamespace) | |||
| if len(input) > 0 && result.ObjectMeta.Name != input { | |||
| fmt.Fprintf(out, "--> Deploying template %s for %q\n", qualifiedName, input) | |||
| fmt.Fprintf(out, "--> Deploying template %s for %q to project %s\n", qualifiedName, input, baseNamespace) | |||
There was a problem hiding this comment.
quote here:
Deploying template %q for ...
|
OK, done. |
|
thx, LGTM |
|
flake #8571 |
|
[merge] |
jim-minter
force-pushed
the
issue10462
branch
from
f111aae to
76dd1c4
Compare
|
rebased and squashed |
|
[merge] |
|
Evaluated for origin test up to 76dd1c4 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10165/) (Base Commit: 3ed3b35) |
|
Evaluated for origin merge up to 76dd1c4 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10223/) (Base Commit: e3a2814) (Image: devenv-rhel7_5200) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10462
Suggested message change to: