Make evacuate aware of replica set and daemon set #11284
Conversation
| return err | ||
| } | ||
|
|
||
| dss, err := e.Options.Kclient.DaemonSets(kapi.NamespaceAll).List(kapi.ListOptions{}) |
There was a problem hiding this comment.
Should we also include pet set pods?
There was a problem hiding this comment.
@Kargakis yeah, which is why i think this need some refactoring love...
There was a problem hiding this comment.
pet sets added. @smarterclayton do you know if we have any helper/utility that knows how to match the pods using MatchExpressions?
| if numPodsWithNoRC > 0 { | ||
| err := fmt.Errorf(`Unable to evacuate some pods because they are not backed by replication controller. | ||
| if numUnmanagedPods > 0 { | ||
| err := fmt.Errorf(`Unable to evacuate some pods because they are not managed by replication controller or replica set or deaemon set. |
There was a problem hiding this comment.
"because they are not managed by any type of controller (replication controller, replica set, daemon set, pet set)" or something similar
|
[test] |
|
Evaluated for origin test up to 010bf86 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9869/) |
|
[merge] |
|
Evaluated for origin merge up to 010bf86 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10038/) (Base Commit: 6d047d3) (Image: devenv-rhel7_5175) |
@Kargakis this is asking for refactoring desperately and I need to find the appropriate helper in upstream to use for matching labels with
unversioned.LabelSelector, but PTAL.Fixes: #11193