Update role binding docs #11344
Merged
Update role binding docs #11344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enj
force-pushed
the
enj/d/role_binding
branch
from
a276f25 to
c3df292
Compare
openshift-bot
added
the
needs-rebase
|
Rebase |
enj
force-pushed
the
enj/d/role_binding
branch
from
c3df292 to
9082c50
Compare
enj
removed
the
needs-rebase
enj
force-pushed
the
enj/d/role_binding
branch
from
9082c50 to
b65108f
Compare
|
+1 |
Signed-off-by: Monis Khan <[email protected]>
enj
force-pushed
the
enj/d/role_binding
branch
from
b65108f to
731169a
Compare
|
Rebased. |
|
Note you only need api review if the doc get worse :) LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10356/) (Image: devenv-rhel7_5216) |
|
Evaluated for origin merge up to 731169a |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 731169a |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10356/) (Base Commit: e1d9196) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just trying to clarify role binding creation based on all the fun @benjaminapetersen had.
Signed-off-by: Monis Khan [email protected]
cc @openshift/api-review