Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oc: add -o revision in rollout latest #11357

Merged
merged 3 commits into from
Oct 20, 2016
Merged

oc: add -o revision in rollout latest #11357

merged 3 commits into from
Oct 20, 2016

Conversation

0xmichalis
Copy link
Contributor

@0xmichalis 0xmichalis commented Oct 13, 2016

@mfojtik ptal

cc: @openshift/cli-review

Now users can wait for specific deployment revisions to finish by:

REVISION=$(oc rollout latest dc/foo -o revision)
oc rollout status dc/foo --revision=$REVISION

Fixes #10864

@0xmichalis
Copy link
Contributor Author

0xmichalis commented Oct 13, 2016

@mfojtik I am also backporting kubernetes/kubernetes#34443 to fix #10864

@fabianofranz
Copy link
Member

LGTM

@0xmichalis
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@0xmichalis
Copy link
Contributor Author

#11370 [test]

@0xmichalis
Copy link
Contributor Author

#11381 [merge]

@0xmichalis
Copy link
Contributor Author

#11381 [merge]

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2016
@0xmichalis 0xmichalis added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2016
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2016
@0xmichalis
Copy link
Contributor Author

#11240 [test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to fd5d49f

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10187/) (Base Commit: f6bd74b)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to fd5d49f

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 20, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10187/) (Base Commit: 7405f17) (Image: devenv-rhel7_5210)

@openshift-bot openshift-bot merged commit d5ba43d into openshift:master Oct 20, 2016
@0xmichalis 0xmichalis deleted the return-revision-from-latest branch October 20, 2016 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants