UPSTREAM: 32662: Change the default volume type of GlusterFS provisioner #11367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let there be 3 replicas by default.
jsafrane
force-pushed
the
pick-gluster-replicas
branch
from
3cd4b0a to
4607180
Compare
|
[test] |
1 similar comment
|
[test] |
|
Evaluated for origin test up to 4607180 |
|
lgtm ! |
|
So the remaining flakes in this PR are similar to #11094 , where it is simply taking longer time than 5 minutes to delete a namespace. I tried to find out, if something is there in the PR which is causing this. But the failling tests have nothing to do with gluster volume provisioning at all. cc @rootfs |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10049/) (Base Commit: ebcc568) |
|
@childsb, can you please approve this PR? |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10049/) (Image: devenv-rhel7_5206) |
|
Evaluated for origin merge up to 4607180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let there be 3 replicas by default.