oc new-app --search: don't require docker hub access #11436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
flake #11240 |
|
#11240 and yum failure |
|
@bparees PTAL |
bparees
requested changes
Oct 19, 2016
| @@ -213,6 +213,8 @@ func (s ImageImportSearcher) Search(precise bool, terms ...string) (ComponentMat | |||
| if image.Status.Status != unversioned.StatusSuccess { | |||
| glog.V(4).Infof("image import failed: %#v", image) | |||
| switch image.Status.Reason { | |||
| case unversioned.StatusReasonInternalError: | |||
| glog.Warningf("Image lookup failed: %s", image.Status.Message) | |||
When using oc new-app --search in environment where OpenShift server could not reach Docker Hub, oc new-app --search had failed for any query. This commit changes the behavior to print a warning and continue with what was found in other sources. Fixes bug 1378647.
mmilata
force-pushed
the
offline-oc-newapp-search
branch
from
ed2ed70 to
1c53eba
Compare
|
Evaluated for origin test up to 1c53eba |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10293/) (Base Commit: 7405f17) |
|
^ yum error |
|
[merge] |
|
Evaluated for origin merge up to 1c53eba |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10383/) (Base Commit: 87f1f55) (Image: devenv-rhel7_5215) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using oc new-app --search in environment where OpenShift server could not reach Docker Hub, oc new-app --search had failed for any query. This commit changes the behavior to print a warning and continue with what was found in other sources.
Fixes bug 1378647.