Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 31607: Add kubectl describe storageclass #11481

Merged
merged 3 commits into from
Oct 22, 2016
Merged

UPSTREAM: 31607: Add kubectl describe storageclass #11481

merged 3 commits into from
Oct 22, 2016

Conversation

jsafrane
Copy link
Contributor

No description provided.

@jsafrane jsafrane added this to the 1.4.0 milestone Oct 21, 2016
@jsafrane jsafrane force-pushed the pick-describe-storageclass branch 2 times, most recently from 212ac8d to 24286b6 Compare October 21, 2016 09:50
@jsafrane jsafrane force-pushed the pick-describe-storageclass branch from 24286b6 to 9aafb07 Compare October 21, 2016 10:27
@jsafrane
Copy link
Contributor Author

[test]

@jsafrane
Copy link
Contributor Author

flakes:

--- FAIL: TestCheckRemoteGit (20.38s)
    source_test.go:37: unexpected error "fatal: unable to access 'https://github.com/openshift/origin/': Could not resolve host: github.com; Name or service not known"

@jsafrane
Copy link
Contributor Author

[test]

@eparis
Copy link
Member

eparis commented Oct 21, 2016

I haven't looked yet between #11475 and this.

@eparis eparis mentioned this pull request Oct 21, 2016
Closed
@jsafrane
Copy link
Contributor Author

@eparis, #11475 already includes code from this PR, i.e. this one could be closed if we want #11475

@eparis
Copy link
Member

eparis commented Oct 21, 2016

you willing to review over there?

@jsafrane jsafrane force-pushed the pick-describe-storageclass branch from 9aafb07 to 79bf00a Compare October 21, 2016 14:05
@jsafrane
Copy link
Contributor Author

Updated with Scott's changes, now contains all code that is in #11475 + it should pass tests

@jsafrane
Copy link
Contributor Author

[test]

@eparis
Copy link
Member

eparis commented Oct 21, 2016 •
edited
Loading

[merge] because it's going to take all day anyway

@screeley44
Copy link
Contributor

@jsafrane - THANKS! It would have taken me some time to figure out the bash stuff, so this def should speed things up

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 79bf00a

@jsafrane
Copy link
Contributor Author

[test] again for lost build ("404 not found")

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 79bf00a

@danmcp danmcp mentioned this pull request Oct 21, 2016
Closed
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10438/) (Base Commit: 636901c)

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 22, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10466/) (Base Commit: 11a00ce) (Image: devenv-rhel7_5224)

@openshift-bot openshift-bot merged commit 47fd7d6 into openshift:master Oct 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jsafrane @eparis @screeley44 @openshift-bot