-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 35608: Update PodAntiAffinity to ignore calls to subresources #11578
Conversation
@mfojtik this is good to merge, since the upstream PR was approved. This will unblock QA testing PDB, so it's quite important to get in asap. |
[Test]ing while waiting on the merge queue |
Oh, that flake was fixed already, lemme rebase my PR. |
f7e2683
to
4cdfcfb
Compare
Evaluated for origin test up to 4cdfcfb |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10861/) (Base Commit: 73c11af) |
We need this to fix https://bugzilla.redhat.com/show_bug.cgi?id=1389255 @ncdc fyi [merge] |
Flake #11682. |
[merge] |
[merge] |
Looks like #9355. |
[merge] |
Evaluated for origin merge up to 4cdfcfb |
What kind of dance should I make to merge this PR 💃 ? Or sacrificing 🐐 🍻 or anything else? |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11072/) (Base Commit: 6abb256) (Image: devenv-rhel7_5307) |
Upon curling Pod's evict endpoint I'm getting:
Resource was marked with kind Pod but was unable to be converted
since the code in antiaffinity admission is trying to cast Pod to Eviction, which fails. This PR is a cherry-pick from upstream that fixes that problem.