Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display warning instead of error if ports 80/443 in use #11600

Merged
merged 1 commit into from
Oct 28, 2016
Merged

Display warning instead of error if ports 80/443 in use #11600

merged 1 commit into from
Oct 28, 2016

Conversation

coreydaley
Copy link
Member

@coreydaley coreydaley commented Oct 26, 2016 •
edited
Loading

Display warnings if ports 80 and/or 443 are already in use instead of an error,
as these ports are only needed for routing requests to the applications

Replaces pull request #10717

@coreydaley
Display warning instead of error if ports 80/443 in use
86f064f 
Display warnings if ports 80 and/or 443 are already in use instead of an error,
as these ports are only needed for routing requests to the applications

Fixes issue #10665 and replaces pull request #10717
@coreydaley
Copy link
Member Author

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 86f064f

@csrwng
Copy link
Contributor

csrwng commented Oct 27, 2016

@coreydaley this change looks good to me and we should make it, but it doesn't quite fix the #10665 issue. We're checking that we can open those ports on the server, which we need to. However, in the case we do port-forwarding and start 'socat' (which is only required for the Mac), we also need to make sure that the client machine allows opening ports 80 and 443. If not, we should print warnings. Maybe we should do that on a separate PR.

@csrwng
Copy link
Contributor

csrwng commented Oct 27, 2016

LGTM [merge]

@csrwng
Copy link
Contributor

csrwng commented Oct 27, 2016

test failure was due to #11560

@csrwng
Copy link
Contributor

csrwng commented Oct 27, 2016

@bparees ptal

@bparees
Copy link
Contributor

bparees commented Oct 27, 2016

[merge]

@bparees
Copy link
Contributor

bparees commented Oct 27, 2016

flake #10773
[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 86f064f

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10757/) (Base Commit: 0403599)

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 28, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10770/) (Base Commit: 5494a7e) (Image: devenv-rhel7_5262)

@openshift-bot openshift-bot merged commit 6c62ba0 into openshift:master Oct 28, 2016
This was referenced Oct 28, 2016
Open
Closed
@coreydaley coreydaley deleted the github_10665_warn_on_router_ports_in_use branch October 28, 2016 14:53
@akram akram mentioned this pull request Jun 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coreydaley @openshift-bot @csrwng @bparees