Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with other cli descriptions #11608

Merged
merged 1 commit into from
Oct 31, 2016
Merged

Align with other cli descriptions #11608

merged 1 commit into from
Oct 31, 2016

Conversation

yu8833
Copy link

@yu8833 yu8833 commented Oct 27, 2016

dot

Signed-off-by: yupeng [email protected]

@danmcp
Copy link

danmcp commented Oct 27, 2016

I would remove the period from the one that has it instead.

@fabianofranz
Copy link
Member

@YuPengZTE thanks for the PR! Note that since this PR changes command docs, you have to run hack/update-generated-docs.sh and add the generated assets.

@yu8833
Copy link
Author

yu8833 commented Oct 31, 2016

Thanks @fabianofranz, I run hack/update-generated-docs.sh, the info is that have no file to commit,like this:
root@yupeng-VirtualBox:/home/yupeng/github.com/openshift/origin# ./hack/update-generated-docs.sh
++ Building go targets for linux/amd64: tools/gendocs tools/genman
++ Placing binaries
/home/yupeng/github.com/openshift/origin/hack/build-go.sh took 1673 seconds
Assets generated in /home/yupeng/github.com/openshift/origin//docs/generated
Assets generated in /home/yupeng/github.com/openshift/origin//docs/man/man1
Assets generated in /home/yupeng/github.com/openshift/origin//docs/man/man1
Assets generated in /home/yupeng/github.com/openshift/origin//docs/man/man1

@fabianofranz
Copy link
Member

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to b0e3ed1

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10845/) (Base Commit: 8b2d509)

@fabianofranz
Copy link
Member

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 31, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10845/) (Image: devenv-rhel7_5279)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to b0e3ed1

@openshift-bot openshift-bot merged commit 74a50b2 into openshift:master Oct 31, 2016
@yu8833 yu8833 deleted the devDot branch November 1, 2016 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants